jp9000/obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

(API Change) Remove pointers from all typedefs

Browse Source 
Typedef pointers are unsafe.  If you do:
typedef struct bla *bla_t;
then you cannot use it as a constant, such as: const bla_t, because
that constant will be to the pointer itself rather than to the
underlying data.  I admit this was a fundamental mistake that must
be corrected.

All typedefs that were pointer types will now have their pointers
removed from the type itself, and the pointers will be used when they
are actually used as variables/parameters/returns instead.

This does not break ABI though, which is pretty nice.
This commit is contained in:
jp9000
2014-09-25 17:44:05 -07:00
parent 4a06960188
commit c9df41c1e2
146 changed files with 3105 additions and 3079 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
plugins/image-source/image-source.c
View File

@@ -5,9 +5,9 @@
obs_source_get_name(context->source), ##__VA_ARGS__)
struct image_source {
obs_source_t source;
obs_source_t *source;
gs_texture_t tex;
gs_texture_t *tex;
uint32_t cx;
uint32_t cy;
};
@@ -17,7 +17,7 @@ static const char *image_source_get_name(void)
return obs_module_text("ImageInput");
}
static void image_source_update(void *data, obs_data_t settings)
static void image_source_update(void *data, obs_data_t *settings)
{
struct image_source *context = data;
const char *file = obs_data_get_string(settings, "file");
@@ -44,7 +44,7 @@ static void image_source_update(void *data, obs_data_t settings)
obs_leave_graphics();
}
static void *image_source_create(obs_data_t settings, obs_source_t source)
static void *image_source_create(obs_data_t *settings, obs_source_t *source)
{
struct image_source *context = bzalloc(sizeof(struct image_source));
context->source = source;
@@ -76,7 +76,7 @@ static uint32_t image_source_getheight(void *data)
return context->cy;
}
static void image_source_render(void *data, gs_effect_t effect)
static void image_source_render(void *data, gs_effect_t *effect)
{
struct image_source *context = data;
if (!context->tex)
@@ -96,9 +96,9 @@ static const char *image_filter =
"JPEG Files (*.jpeg *.jpg);;"
"GIF Files (*.gif)";
static obs_properties_t image_source_properties(void)
static obs_properties_t *image_source_properties(void)
{
obs_properties_t props = obs_properties_create();
obs_properties_t *props = obs_properties_create();
obs_properties_add_path(props,
"file", obs_module_text("File"),