jp9000
/
obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libobs: Don't strip whitespace from config values 

A plugin that saves whitespace-only data would crash OBS on startup as
the whitespace stripping would send the string length negative. While
that bug is fixed in this commit, there is also no good reason that OBS
is stripping whitespace to begin with. All data going into the configs
should be well formed and some plugins legitimately wish to save
whitespace as a config option (eg for search / replace characters).
master
Richard Stanway 2020-02-23 04:02:42 +01:00
parent ee4cbb1199
commit 862f16285f
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
libobs/util/config-file.c
View File

@ -95,7 +95,7 @@ config_t *config_create(const char *file)
static inline void remove_ref_whitespace(struct strref *ref)
{
if (ref->array) {
while (is_whitespace(*ref->array)) {
while (ref->len && is_whitespace(*ref->array)) {
ref->array++;
ref->len--;
}
@ -130,7 +130,7 @@ static bool config_parse_string(struct lexer *lex, struct strref *ref, char end)
strref_add(ref, &token.text);
}
remove_ref_whitespace(ref);
//remove_ref_whitespace(ref);
return success;
}