jp9000/obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libobs: Don't call unlink unnecessarily

Browse Source 
A file rename will automatically replace the old file if an older file
exists, and will do so automatically.  Unlinking is unnecessary, and may
have a chance of preventing that move operation from being atomic.
This commit is contained in:
jp9000 2017-05-04 18:19:46 -07:00
parent 08a94072a0
commit 85a6d16258
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
libobs/obs-data.c
View File

@ -682,7 +682,6 @@ obs_data_t *obs_data_create_from_json_file_safe(const char *json_file,
/* delete current file if corrupt to prevent it from /* delete current file if corrupt to prevent it from
* being backed up again */ * being backed up again */
os_unlink(json_file);
os_rename(backup_file.array, json_file); os_rename(backup_file.array, json_file);
file_data = obs_data_create_from_json_file(json_file); file_data = obs_data_create_from_json_file(json_file);