jp9000/obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

UI: Log generic stream startup failures

Browse Source 
These code paths had no logging on failure, resulting in a log file that
would confuse people attempting to perform support for users.
This commit is contained in:
jp9000 2017-10-06 04:48:24 -07:00
parent a0e8c7a5c1
commit 720a28aeb9
1 changed files with 22 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

24
UI/window-basic-main-outputs.cpp
View File

@ -664,8 +664,11 @@ bool SimpleOutput::StartStreaming(obs_service_t *service)
streamOutput = obs_output_create(type, "simple_stream",
nullptr, nullptr);
if (!streamOutput)
if (!streamOutput) {
blog(LOG_WARNING, "Creation of stream output type '%s' "
"failed!", type);
return false;
}
obs_output_release(streamOutput);
streamDelayStarting.Connect(
@ -756,6 +759,13 @@ bool SimpleOutput::StartStreaming(obs_service_t *service)
return true;
}
const char *error = obs_output_get_last_error(streamOutput);
bool has_last_error = error && *error;
blog(LOG_WARNING, "Stream output type '%s' failed to start!%s%s",
type,
has_last_error ? " Last Error: " : "",
has_last_error ? error : "");
return false;
}
@ -1417,8 +1427,11 @@ bool AdvancedOutput::StartStreaming(obs_service_t *service)
streamOutput = obs_output_create(type, "adv_stream",
nullptr, nullptr);
if (!streamOutput)
if (!streamOutput) {
blog(LOG_WARNING, "Creation of stream output type '%s' "
"failed!", type);
return false;
}
obs_output_release(streamOutput);
streamDelayStarting.Connect(
@ -1509,6 +1522,13 @@ bool AdvancedOutput::StartStreaming(obs_service_t *service)
return true;
}
const char *error = obs_output_get_last_error(streamOutput);
bool has_last_error = error && *error;
blog(LOG_WARNING, "Stream output type '%s' failed to start!%s%s",
type,
has_last_error ? " Last Error: " : "",
has_last_error ? error : "");
return false;
}