jp9000
/
obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mac-vth264: Set RealTime property to False 

While the Apple documentation currently seems to indicate that we should
set RealTime to True, it appears that this may be causing issues with
the encoder not being able to meet the target frame rate. Both FFmpeg
and Handbrake have recently explicitly set this value to False, and
preliminary tests seem to indicate that setting this to false in OBS has
favorable results.
master
Ryan Foster 2022-01-28 09:27:18 -05:00 committed by Jim
parent 6360b2e425
commit 5bbb36acf8
1 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/mac-vth264/encoder.c
View File

@ -319,13 +319,13 @@ static bool create_encoder(struct vt_h264_encoder *enc)
// This can fail depending on hardware configuration
code = session_set_prop(s, kVTCompressionPropertyKey_RealTime,
kCFBooleanTrue);
kCFBooleanFalse);
if (code != noErr)
log_osstatus(LOG_WARNING, enc,
"setting "
"kVTCompressionPropertyKey_RealTime, "
"frame delay might be increased",
code);
log_osstatus(
LOG_WARNING, enc,
"setting kVTCompressionPropertyKey_RealTime failed, "
"frame delay might be increased",
code);
STATUS_CHECK(session_set_prop(s, kVTCompressionPropertyKey_ProfileLevel,
obs_to_vt_profile(enc->profile)));