jp9000/obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

libobs: Add missing mutex unlocks to some filter functions

Browse Source 
Detected by Coverity Scan (CID 12831, 12830)
This commit is contained in:
Richard Stanway
2015-10-12 22:51:03 +02:00
parent 55dd8f8726
commit 4b9d0256c8
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libobs/obs-source.c
View File

@@ -1532,6 +1532,7 @@ void obs_source_filter_add(obs_source_t *source, obs_source_t *filter)
if (da_find(source->filters, &filter, 0) != DARRAY_INVALID) {
blog(LOG_WARNING, "Tried to add a filter that was already "
"present on the source");
pthread_mutex_unlock(&source->filter_mutex);
return;
}
@@ -1565,8 +1566,10 @@ static bool obs_source_filter_remove_refless(obs_source_t *source,
pthread_mutex_lock(&source->filter_mutex);
idx = da_find(source->filters, &filter, 0);
if (idx == DARRAY_INVALID)
if (idx == DARRAY_INVALID) {
pthread_mutex_unlock(&source->filter_mutex);
return false;
}
if (idx > 0) {
obs_source_t *prev = source->filters.array[idx-1];