jp9000/obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

linux-pipewire: Remove ellipses from log messages

Browse Source 
Ellipses in log messages bring a tone of vagueness and insecurity
that does not match the geist of the OBS Studio community. We're
a bold, industry-leading community producing software that is at
the heart of the biggest services of today's world. When it comes
to PipeWire and Wayland adoption, we're quite literally the app
that protocols and portals are designed for.

Therefore, it is unacceptable that the log messages in the PipeWire
capture don't communicate how strong of a community we are. Not
only that, these ellipses bring harm on the long run. After all,
who on their right mind would design protocols, portals, and user
interactions for an app that doesn't even log their messages in
accordance to its community values?

Our logs must shout strength. They must reflect that OBS Studio
is here to stay. Readers of such logs must fasten their seatbelts
before opening these files. Competition tremble with dread and
fear when presented with these logs. Only extreme metal singers
should be able to read these logs out loud.

No compromise.

Remove ellipses from PipeWire log messages.
This commit is contained in:
Georges Basile Stavracas Neto 2022-04-02 09:52:42 -03:00 committed by Jim
parent 25fe22a489
commit 2534e549f9
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/linux-pipewire/pipewire.c
View File

@ -582,7 +582,7 @@ static void renegotiate_format(void *data, uint64_t expirations)
obs_pipewire_data *obs_pw = (obs_pipewire_data *)data;
const struct spa_pod **params = NULL;
blog(LOG_INFO, "[pipewire] Renegotiating stream ...");
blog(LOG_INFO, "[pipewire] Renegotiating stream");
pw_thread_loop_lock(obs_pw->thread_loop);
@ -973,7 +973,7 @@ static void play_pipewire_stream(obs_pipewire_data *obs_pw)
PW_STREAM_FLAG_AUTOCONNECT | PW_STREAM_FLAG_MAP_BUFFERS, params,
n_params);
blog(LOG_INFO, "[pipewire] Playing stream %p…", obs_pw->stream);
blog(LOG_INFO, "[pipewire] Playing stream %p", obs_pw->stream);
pw_thread_loop_unlock(obs_pw->thread_loop);
bfree(params);
@ -1136,7 +1136,7 @@ static void start(obs_pipewire_data *obs_pw)
new_request_path(obs_pw, &request_path, &request_token);
blog(LOG_INFO, "[pipewire] Asking for %s…",
blog(LOG_INFO, "[pipewire] Asking for %s",
capture_type_to_string(obs_pw->capture_type));
call = subscribe_to_signal(obs_pw, request_path,