jp9000/obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove 'locale' parameter from all callbacks

Browse Source 
The locale parameter was a mistake, because it puts extra needless
burden upon the module developer to have to handle this variable for
each and every single callback function.  The parameter is being removed
in favor of a single centralized module callback function that
specifically updates locale information for a module only when needed.
This commit is contained in:
jp9000
2014-06-25 00:13:00 -07:00
parent 74b4743bce
commit 0b4a259e56
38 changed files with 125 additions and 160 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
plugins/mac-capture/mac-audio.c
View File

@@ -628,17 +628,15 @@ static void coreaudio_uninit(struct coreaudio_data *ca)
/* ------------------------------------------------------------------------- */
static const char *coreaudio_input_getname(const char *locale)
static const char *coreaudio_input_getname(void)
{
/* TODO: Locale */
UNUSED_PARAMETER(locale);
return "CoreAudio Input Capture";
}
static const char *coreaudio_output_getname(const char *locale)
static const char *coreaudio_output_getname(void)
{
/* TODO: Locale */
UNUSED_PARAMETER(locale);
return "CoreAudio Output Capture";
}
@@ -704,7 +702,7 @@ static void *coreaudio_create_output_capture(obs_data_t settings,
return coreaudio_create(settings, source, false);
}
static obs_properties_t coreaudio_properties(const char *locale, bool input)
static obs_properties_t coreaudio_properties(bool input)
{
obs_properties_t props = obs_properties_create();
obs_property_t property;
@@ -732,14 +730,14 @@ static obs_properties_t coreaudio_properties(const char *locale, bool input)
return props;
}
static obs_properties_t coreaudio_input_properties(const char *locale)
static obs_properties_t coreaudio_input_properties(void)
{
return coreaudio_properties(locale, true);
return coreaudio_properties(true);
}
static obs_properties_t coreaudio_output_properties(const char *locale)
static obs_properties_t coreaudio_output_properties(void)
{
return coreaudio_properties(locale, false);
return coreaudio_properties(false);
}
struct obs_source_info coreaudio_input_capture_info = {