jp9000/obs-studio
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove 'locale' parameter from all callbacks

Browse Source 
The locale parameter was a mistake, because it puts extra needless
burden upon the module developer to have to handle this variable for
each and every single callback function.  The parameter is being removed
in favor of a single centralized module callback function that
specifically updates locale information for a module only when needed.
This commit is contained in:
jp9000
2014-06-25 00:13:00 -07:00
parent 74b4743bce
commit 0b4a259e56
38 changed files with 125 additions and 160 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
plugins/linux-pulseaudio/pulse-input.c
View File

@@ -281,7 +281,7 @@ skip:
/**
* Get plugin properties
*/
static obs_properties_t pulse_properties(const char *locale, bool input)
static obs_properties_t pulse_properties(bool input)
{
obs_properties_t props = obs_properties_create();
obs_property_t devices = obs_properties_add_list(props, "device_id",
@@ -295,14 +295,14 @@ static obs_properties_t pulse_properties(const char *locale, bool input)
return props;
}
static obs_properties_t pulse_input_properties(const char *locale)
static obs_properties_t pulse_input_properties(void)
{
return pulse_properties(locale, true);
return pulse_properties(true);
}
static obs_properties_t pulse_output_properties(const char *locale)
static obs_properties_t pulse_output_properties(void)
{
return pulse_properties(locale, false);
return pulse_properties(false);
}
/**
@@ -366,15 +366,15 @@ static void pulse_output_defaults(obs_data_t settings)
/**
* Returns the name of the plugin
*/
static const char *pulse_input_getname(const char *locale)
static const char *pulse_input_getname(void)
{
UNUSED_PARAMETER(locale);
/* TODO: locale */
return "Pulse Audio Input Capture";
}
static const char *pulse_output_getname(const char *locale)
static const char *pulse_output_getname(void)
{
UNUSED_PARAMETER(locale);
/* TODO: locale */
return "Pulse Audio Output Capture";
}