Commit Graph

190 Commits (master)

Author SHA1 Message Date
Bendito999 9eac9ac067 ID3 Data Windows Explorer Compatibility
Windows Explorer and Media Player cannot read ID3v2 data without first having ID3v1 data present. This makes it necessary to first enable ID3v1 if it was not already enabled on the files (which apparently Bandcamp does not)

It's probably easy to miss this on any reasonable media player or Linux ;)

More syntax info from 
http://mutagen.readthedocs.org/en/latest/api/id3.html#mutagen.id3.ID3.save

Original solution from post on https://code.google.com/p/mutagen/wiki/Tutorial

>Comment by jehoshu...@gmail.com, Oct 4, 2011
>After many hours . . .
>I discovered why on save() the information disappears in Windows Explorer and Media Player . . .
>. . . Windows Explorer and Media Player only read, and mutagen does NOT write, ID3v1 tags!
>And as far as I can tell from the LIMITED documentation, mutagen will READ BUT NOT WRITE ID3v1  tags.
>I further discovered, while playing with WINAMP, that it is possible to have BOTH ID3v1 and ID3v2 tags in a file, BUT Windows Explorer and Media Player require the ID3v1 tags to come first!
>But there's no way to explicitly ensure that mutagen follows this requirement.
>Does anybody know ID3v1 well enough to dive into the source code and fix this?
>I'm using Windows 7, Python 2.7, Mutagen 1.20. I really hope this helps someone avoid spending painful amounts time!
2016-09-04 15:51:38 -04:00
Iheanyi Ekechukwu 50b0a7781a Merge pull request #51 from Mixbo/master
Changed hardcoded python to env PATH
2016-04-01 10:37:34 -04:00
Iheanyi Ekechukwu 6c0d08a48d Merge pull request #52 from Mixbo/encoding
Encoding
2016-03-28 16:09:57 -07:00
Mixbo 35b0000f62 Encoding 2016-03-27 16:47:34 -04:00
Mixbo 1374abf9dd Forces python2 2016-03-26 12:03:46 -04:00
Mixbo b3fd3a067f Changed hardcoded python to env PATH 2016-03-26 11:55:17 -04:00
Iheanyi Ekechukwu 58ed24f83f Merge branch 'master' of github.com:iheanyi/bandcamp-dl 2016-03-15 07:15:26 -04:00
Iheanyi Ekechukwu 90e87ff4f7 Version bump. 2016-03-15 07:15:15 -04:00
Iheanyi Ekechukwu eb8ecfe66b Merge pull request #45 from PedroLopes/master
Added: print that states how many tracks are still to be processed + Fixed: tract title encoding caused crash on prints
2016-02-27 10:37:38 -06:00
Pedro Lopes a43031d392 spotted a bug on the prints with german chars such as ä, added utf-8 encode and seems fine 2016-02-25 16:12:05 +01:00
Pedro Lopes 6f89d3a11e minor fix on print 2016-02-25 15:24:09 +01:00
Pedro Lopes de4726aba1 added a Fetching track 1 of N message to the album download function. 2016-02-25 15:20:40 +01:00
Iheanyi Ekechukwu ac7dea2fec Fix bugs for downloading individual tracks. 2015-12-27 01:58:24 -05:00
Iheanyi Ekechukwu abb625407c Merge pull request #43 from iheanyi/packaging
Add packaging stuff for installation via Pip
2015-12-11 18:39:05 -06:00
Iheanyi Ekechukwu 6d4c1032b9 Update README file 2015-12-11 18:37:53 -06:00
Iheanyi Ekechukwu 683cda2abf Update version again. -_- 2015-12-11 18:36:18 -06:00
Iheanyi Ekechukwu ba0e1832ef Version bump, fix a bug with dependencies. 2015-12-11 18:27:55 -06:00
Iheanyi Ekechukwu 9383b60030 Add files necessary for packaging. 2015-12-11 18:03:14 -06:00
Iheanyi Ekechukwu ece554324f Rename Python file to something more suitable. 2015-12-11 18:02:43 -06:00
Iheanyi Ekechukwu 278ceae2e1 Rename directory for Python conventions. 2015-12-11 16:39:03 -06:00
Iheanyi Ekechukwu 166a0c8673 Add versions to the dependencies list through a pip freeze. :) 2015-12-11 16:20:00 -06:00
Iheanyi Ekechukwu 83554e891d Lock in Ply version. 2015-12-11 14:27:03 -06:00
Iheanyi Ekechukwu 54a6524cc3 Update code to take into consideration files that may not have HTTP, additionally, update gitignore. 2015-12-11 14:19:02 -06:00
Iheanyi Ekechukwu c12a8a35dc Add lxml dependency. 2015-12-11 14:02:06 -06:00
Iheanyi Ekechukwu 7b593bda74 Merge pull request #41 from leonaard/master
Remove junk from git history
2015-12-07 20:25:20 -06:00
Iheanyi Ekechukwu 4287cc869e Merge pull request #39 from vladdeSV/patch-1
Fix typo in README
2015-12-03 13:19:19 -06:00
Vladde 9660808373 Fix typo 2015-11-09 18:49:10 +01:00
Iheanyi Ekechukwu 6a0ba44862 Merge pull request #31 from forsenonlhaimaisentito/fixes-1
Minor fixes, especially the odd default basedir behaviour
2015-10-15 10:07:43 -04:00
forsenonlhaimaisentito f1a23fd185 Track number filename part is zero-padded for older players 2015-09-11 16:09:24 +02:00
forsenonlhaimaisentito 55d22a7741 Default basedir is user's cwd instead of script's directory 2015-09-11 14:26:36 +02:00
forsenonlhaimaisentito 05836498e4 Explicitly use the lxml parser to avoid BS warnings 2015-09-11 14:26:12 +02:00
forsenonlhaimaisentito 715d03bb4f Fixed typo in README.md 2015-09-11 14:25:49 +02:00
Iheanyi Ekechukwu 1c3c25c984 Merge pull request #21 from Schniz/master
Updated README.md
2014-12-02 11:15:15 -05:00
Gal Schlezinger 790982fa32 Updated README.md
Added installation process
2014-10-04 12:49:03 +03:00
Iheanyi Ekechukwu 94f3f17ba7 Merge pull request #16 from josefnpat/patch-1
Adding slugify deps to docs and changing mode bits
2014-09-11 20:29:34 -04:00
Seppi 36bac7554b Setting mode bits to better identify executables
Adding a+x to bandcamp-dl.py so it's identified as the main executable
Removing a-x to bandcamp-dl.py so it's recognized as a dep

Relates to #15
2014-08-07 19:10:21 -04:00
Seppi 5767fe4c27 Add slugify dep to README.md
Closes #15
2014-08-07 19:09:27 -04:00
Seppi e702fda691 Adding slugify to the requirements.txt 2014-08-07 19:02:52 -04:00
Iheanyi Ekechukwu f141c363d7 Merge pull request #14 from dgbc/slugify
slugify dependency added
2014-07-29 15:56:56 -05:00
Diego 17b8e85086 slugify dependency added 2014-07-29 17:52:09 -03:00
Iheanyi Ekechukwu 1e3159bd35 Merge pull request #12 from mtchllbrrn/master
Fix album art bug, typos
2014-07-07 20:16:20 -05:00
mtchllbrrn 1dcfc99957 Fix typos 2014-07-07 20:11:38 -05:00
mtchllbrrn f1d85f22c9 Fix typos 2014-07-07 20:10:47 -05:00
mtchllbrrn 6fffd4fce3 Fix typos
Just a couple small typos
2014-07-07 20:10:23 -05:00
mtchllbrrn cfb8c3effb Fix album art bug
Previously, script would hang on a Bandcamp without album art, as here:  http://yesmaam.bandcamp.com/album/stirrin-da-mudd

Fix properly handles such a case by displaying a message after encoding.
2014-07-07 20:07:39 -05:00
Iheanyi Ekechukwu 7b07e8086f Merge pull request #9 from JBKahn/master
adding unicode support for return and cleaning up imports and spaces
2014-06-26 08:40:57 -05:00
Joseph Kahn 320ba6bdea more minor changes 2014-06-08 00:14:56 -04:00
Joseph Kahn 27d6c416f9 accidentally put unicode twice 2014-06-07 23:09:31 -04:00
Joseph Kahn 7baa554d33 adding unicode support for return and cleaning up imports and spaces 2014-06-07 23:04:16 -04:00
Iheanyi Ekechukwu 11a2df78c7 Merge pull request #8 from bjesus/master
Support for albumart downloading and date tag
2014-06-03 21:00:48 -05:00