facebook/zstd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2540 from senhuang42/fix_dds_supported

Browse Source 
Fix dedicated dict search isSupported() requirements.
This commit is contained in:
sen 2021-03-17 23:25:53 -04:00 committed by GitHub
commit eace4abc25
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
lib/compress/zstd_compress.c
View File

@ -5186,7 +5186,10 @@ static ZSTD_compressionParameters ZSTD_dedicatedDictSearch_getCParams(int const
static int ZSTD_dedicatedDictSearch_isSupported( static int ZSTD_dedicatedDictSearch_isSupported(
ZSTD_compressionParameters const* cParams) ZSTD_compressionParameters const* cParams)
{ {
return (cParams->strategy >= ZSTD_greedy) && (cParams->strategy <= ZSTD_lazy2); return (cParams->strategy >= ZSTD_greedy)
&& (cParams->strategy <= ZSTD_lazy2)
&& (cParams->hashLog >= cParams->chainLog)
&& (cParams->chainLog <= 24);
} }
/** /**

2
tests/playTests.sh
View File

@ -805,6 +805,8 @@ println "- Dictionary compression roundtrip"
zstd -f tmp -D tmpDict zstd -f tmp -D tmpDict
zstd -d tmp.zst -D tmpDict -fo result zstd -d tmp.zst -D tmpDict -fo result
$DIFF "$TESTFILE" result $DIFF "$TESTFILE" result
println "- Dictionary compression with hlog < clog"
zstd -6f tmp -D tmpDict --zstd=clog=25,hlog=23
println "- Dictionary compression with btlazy2 strategy" println "- Dictionary compression with btlazy2 strategy"
zstd -f tmp -D tmpDict --zstd=strategy=6 zstd -f tmp -D tmpDict --zstd=strategy=6
zstd -d tmp.zst -D tmpDict -fo result zstd -d tmp.zst -D tmpDict -fo result