facebook/zstd
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #2886 from terrelln/issue-2865

Browse Source 
[test] Test that the exec-stack bit isn't set on libzstd.so
This commit is contained in:
Nick Terrell 2021-12-01 13:05:35 -05:00 committed by GitHub
commit e34e58b458
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
.github/workflows/dev-short-tests.yml vendored
View File

@ -117,11 +117,11 @@ jobs:
make -C zlibWrapper test make -C zlibWrapper test
make -C zlibWrapper valgrindTest make -C zlibWrapper valgrindTest
lz4-threadpool-partial-libs: lz4-threadpool-libs:
runs-on: ubuntu-latest runs-on: ubuntu-latest
steps: steps:
- uses: actions/checkout@v2 - uses: actions/checkout@v2
- name: LZ4, thread pool, and partial libs testslib wrapper test - name: LZ4, thread pool, and libs build testslib wrapper test
run: | run: |
make lz4install make lz4install
make -C tests test-lz4 make -C tests test-lz4
@ -129,7 +129,7 @@ jobs:
make clean make clean
make -C tests test-pool make -C tests test-pool
make clean make clean
bash tests/libzstd_partial_builds.sh bash tests/libzstd_builds.sh
gcc-make-tests-32bit: gcc-make-tests-32bit:
runs-on: ubuntu-latest runs-on: ubuntu-latest

9
tests/libzstd_partial_builds.sh → tests/libzstd_builds.sh
View File

@ -23,14 +23,19 @@ mustBeAbsent() {
# default compilation : all features enabled - no zbuff # default compilation : all features enabled - no zbuff
$ECHO "testing default library compilation" $ECHO "testing default library compilation"
CFLAGS= make -C $DIR/../lib libzstd.a > $INTOVOID CFLAGS= make -C $DIR/../lib libzstd libzstd.a > $INTOVOID
nm $DIR/../lib/libzstd.a | $GREP "\.o" > tmplog nm $DIR/../lib/libzstd.a | $GREP "\.o" > tmplog
isPresent "zstd_compress.o" isPresent "zstd_compress.o"
isPresent "zstd_decompress.o" isPresent "zstd_decompress.o"
isPresent "zdict.o" isPresent "zdict.o"
isPresent "zstd_v07.o" isPresent "zstd_v07.o"
mustBeAbsent "zbuff_compress.o" mustBeAbsent "zbuff_compress.o"
$RM $DIR/../lib/libzstd.a tmplog $RM tmplog
# Check that the exec-stack bit isn't set
readelf -lW $DIR/../lib/libzstd.so | $GREP "GNU_STACK" > tmplog
mustBeAbsent "RWE"
$RM $DIR/../lib/libzstd.a $DIR/../lib/libzstd.so* tmplog
# compression disabled => also disable zdict # compression disabled => also disable zdict
$ECHO "testing with compression disabled" $ECHO "testing with compression disabled"