The cache should be disabled as users from different locations will
get different results for the same query (basically location enabled
IA should have cache disabled). The test cases should be cleaned by
removing obsolete test cases from the suite.
* obsolete test cases removed
* cache disabled
The code coverage will be complete when there are test cases for a multitude
of queries. Also, as the goodie always return the same set of results for the
trigger query - cache can be set.
* cache set
* added test cases
There should be more tests cases added to the suite for code coverage.
PR 3096 was merged before completion of test suite and it has to be
completed.
* test cases added
We're not actually getting a test count from test_zci. Someday soon this
will reconcile exactly with the number of `test_zci` calls you make, but
it clearly does not today (see the extra 2 factor).
Rather than try to predict which version is running these tests, remove
the plan for now.
This explicity sets the caching behavior for all goodies. Goodies which
did not have caching behavior set in their package have had it added.
Similarly for the tests.
This resulted in a number of changes for caching behavior, mostly
moving towards more frequent caching.
I identified three cases where goodies should not be cached. They are when
the result depends upon:
- some random element,
- the time of day or year (as with relative dates), or
- the location of the requesting user
In all other cases, I presumed that the goodies were sufficiently
deterministic in their output to warrant caching.
NaveenKarippai
Rob Emery
Ben Moon
Matt Miller
Jag Talon
Dylan Lloyd