Based primarily on feedback from @moollaza:
- Straighten up the English a bit to make it more comprehensible.
- Move comments before the code they describe.
By their own documentation, the NBS submodules contain idiosyncratic
color names which are not well-suited to a general purpose color code
search.
In particular, NBS_ISCC::M contains a color called 'email' which caused
a confusing result for 'HTML email'.
The main NBS colors are included because they seem reasonable enough as
color names.
This fixes#490 and possibly partially addresses #454 and #442, I guess.
Also includes some testing ideas from @mintsoft.
In addition to fixing #378, this should also make it easier if it
turns out that there are more JIRA trackers to be supported later.
The major overhead is the crazy-long generated regex trigger for
recognizing the tickets.
I am not claiming this is entirely the correct way to do this in this
package, just that it works fairly easily to expand the scope of the
Conversions goodie, as well.
Gonna need feedback from @moollaza and @mintsoft.
On the upside, I found a bug in the styler code by writing a test here!
Considering how all of this works, I'm not sure roles are quite the
right fit. It seems like we might just want a shared "Utility" package
or namespace to let us have access to some common library functions.
DDG::GoodieRole::NumberStyle is a particularly horrible name because
it's not even a role!
Also, the comments suck.
But such is the nature of a proof-of-concept.
This would be better with some proper parsing, but this resolves some
issues with the current HTML output, making it raise things to
arbitrarily high superscripting levels based on what it seems to look
like.
I think this makes it somewhat easier to follow the intent here. We're
just trying to convert these two known strings into different output
formats, so wrapping that up seems like a good idea.
The old version clearly worked, but it was clunky and somewhat
inexplciable. While reading up on something else, I discovered `perldoc
quotemeta` which resolves this in a much more predictable and correct
way.
loganom
Matt Miller
Dylan Lloyd
Jag Talon
Rob Emery
gdrooid
nishanths
Pattarawat Chormai
Zaahir Moolla
Nathan Korth