duckduckgo
/
zeroclickinfo-goodies
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

RegexCheatSheet.pm: Locking down regex for simple character matches & added tests

master
Rob Emery 2013-11-14 19:51:11 +00:00
parent d5765807c0
commit cff1d64eda
2 changed files with 17 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
lib/DDG/Goodie/RegexCheatSheet.pm
View File

@ -172,7 +172,7 @@ handle remainder => sub {
my $syntax_key = $_; my $syntax_key = $_;
# Let the user provide [a-e], [1-2], nice simple examples only! # Let the user provide [a-e], [1-2], nice simple examples only!
if ($_ =~ /\[([a-zA-Z0-9])\-([a-zA-Z0-9])\]/) { if ($_ =~ /^\[([a-zA-Z0-9])\-([a-zA-Z0-9])\]$/) {
return unless are_valid_char_classes($1, $2); return unless are_valid_char_classes($1, $2);
#if there are < 3 between them then output all between them, otherwise "0 or 1 .. or 9" style #if there are < 3 between them then output all between them, otherwise "0 or 1 .. or 9" style
my $range_string = ""; my $range_string = "";

16
t/RegexCheatSheet.t
View File

@ -38,10 +38,26 @@ ddg_goodie_test(
'[M-Y] - Single character range (M or N ... or Y)', '[M-Y] - Single character range (M or N ... or Y)',
html => '<code> [M-Y] </code> - Single character range (M or N ... or Y)' html => '<code> [M-Y] </code> - Single character range (M or N ... or Y)'
), ),
'regex [3-5]' => test_zci(
'[3-5] - Single character range (3 or 4 or 5)',
html => '<code> [3-5] </code> - Single character range (3 or 4 or 5)'
),
'regex [1-2]' => test_zci( 'regex [1-2]' => test_zci(
'[1-2] - Single character range (1 or 2)', '[1-2] - Single character range (1 or 2)',
html => '<code> [1-2] </code> - Single character range (1 or 2)' html => '<code> [1-2] </code> - Single character range (1 or 2)'
), ),
'regex [b-X]' => undef,
'regex [a-Z]' => undef,
'regex [Y-E]' => undef,
'regex [A-a]' => undef,
'regex [z-a]' => undef,
'regex [a-1]' => undef,
'regex [1-a]' => undef,
'regex [1-1]' => undef,
'regex [3-2]' => undef,
'regex [a-]' => undef,
'regex [4-8] fo sho!' => undef,
'regex foop [1-3]' => undef,
); );
done_testing; done_testing;