duckduckgo
/
zeroclickinfo-goodies
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Updates AspectRatio Goodie Re: #2767 (#2843)

master
Hugo Thiessard 2016-04-28 20:30:29 +02:00 committed by Ben Moon
parent c54a2b94d8
commit c55ecbe885
2 changed files with 30 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
lib/DDG/Goodie/AspectRatio.pm
View File

@ -27,11 +27,15 @@ handle remainder => sub {
return unless $result;
return "Aspect ratio: $result ($pretty_ratio)",
structured_answer => {
input => [$pretty_ratio],
operation => 'Aspect ratio',
result => $result
};
structured_answer => {
data => {
title => $result,
subtitle => 'Aspect ratio: ' . $pretty_ratio,
},
templates => {
group => 'text',
}
};
}
};

55
t/AspectRatio.t
View File

@ -8,42 +8,29 @@ use DDG::Test::Goodie;
zci answer_type => 'aspect_ratio';
zci is_cached => 1;
ddg_goodie_test([qw(
DDG::Goodie::AspectRatio
)
],
'aspect ratio 4:3 640:?' => test_zci(
'Aspect ratio: 640:480 (4:3)',
sub build_structured_answer {
my ($pretty_ratio, $result) = @_;
return 'Aspect ratio: ' . $result . ' (' . $pretty_ratio . ')',
structured_answer => {
input => ['4:3'],
operation => 'Aspect ratio',
result => '640:480'
data => {
title => $result,
subtitle => 'Aspect ratio: ' . $pretty_ratio
},
templates => {
group => 'text'
}
}
),
'aspect ratio 4:3 ?:480' => test_zci(
'Aspect ratio: 640:480 (4:3)',
structured_answer => {
input => ['4:3'],
operation => 'Aspect ratio',
result => '640:480'
}
),
'aspect ratio 1:1.5 20:?' => test_zci(
'Aspect ratio: 20:30 (1:1.5)',
structured_answer => {
input => ['1:1.5'],
operation => 'Aspect ratio',
result => '20:30'
}
),
'aspect ratio 1:1.5 ?:15' => test_zci(
'Aspect ratio: 10:15 (1:1.5)',
structured_answer => {
input => ['1:1.5'],
operation => 'Aspect ratio',
result => '10:15'
}
),
}
sub build_test { test_zci(build_structured_answer(@_)) }
ddg_goodie_test(
[qw(DDG::Goodie::AspectRatio)],
'aspect ratio 4:3 640:?' => build_test('4:3', '640:480'),
'aspect ratio 4:3 ?:480' => build_test('4:3', '640:480'),
'aspect ratio 1:1.5 20:?' => build_test('1:1.5', '20:30'),
'aspect ratio 1:1.5 ?:15' => build_test('1:1.5', '10:15')
);
done_testing;