duckduckgo
/
zeroclickinfo-goodies
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ColorCodes: treat "code" as semantic noise. 

We want to allow the string "code" to be used in the triggering query,
but we want it to have no effect on how the query is understood
or processed.

Addresses issue #454.
master
Matt Miller 2014-08-28 17:20:15 -04:00
parent 2c3169c4b6
commit bc7e87be22
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/DDG/Goodie/ColorCodes.pm
View File

@ -62,6 +62,9 @@ sub percentify {
return @out;
}
my %trigger_invert = map { $_ => 1 } (qw( inverse negative opposite ));
my %trigger_ignore = map { $_ => 1 } (qw( code ));
handle matches => sub {
my $type;
my $color;
@ -71,12 +74,9 @@ handle matches => sub {
next unless defined $_;
my $q = lc;
$type = $types{$q} if exists $types{$q};
if ($q =~ /\b(?:inverse|negative|opposite|code)\b/) {
if ($trigger_invert{$q}) {
$inverse = 1;
}
else {
} elsif (!$trigger_ignore{$q}) {
$color = $q unless defined $type && exists $types{$q};
}
}

4
t/ColorCodes.t
View File

@ -48,6 +48,10 @@ ddg_goodie_test(
'Hex: #202428 ~ rgb(32, 36, 40) ~ rgb(13%, 14%, 16%) ~ hsl(210, 11%, 14%) ~ cmyb(20%, 10%, 0%, 84%)',
html => qq(<div style="background:#202428;border:2px solid #999;height:30px;width:30px;margin:5px;margin-right:10px;margin-top:3px;float:left;"></div>Hex: #202428 ~ rgb(32, 36, 40) ~ rgb(13%, 14%, 16%) ~ hsl(210, 11%, 14%) ~ cmyb(20%, 10%, 0%, 84%) [<a href='http://labs.tineye.com/multicolr#colors=202428;weights=100;'>Images</a>] [<a href='http://www.color-hex.com/color/202428' title='Tints, information and similar colors on color-hex.com'>Info</a>]),
),
'red html code' => test_zci(
'Hex: #ff0000 ~ rgb(255, 0, 0) ~ rgb(100%, 0%, 0%) ~ hsl(0, 100%, 50%) ~ cmyb(0%, 100%, 100%, 0%)',
html => qq(<div style="background:#ff0000;border:2px solid #999;height:30px;width:30px;margin:5px;margin-right:10px;margin-top:3px;float:left;"></div>Hex: #ff0000 ~ rgb(255, 0, 0) ~ rgb(100%, 0%, 0%) ~ hsl(0, 100%, 50%) ~ cmyb(0%, 100%, 100%, 0%) [<a href='http://labs.tineye.com/multicolr#colors=ff0000;weights=100;'>Images</a>] [<a href='http://www.color-hex.com/color/ff0000' title='Tints, information and similar colors on color-hex.com'>Info</a>]),
),
'bluishblack html' => undef,
'HTML email' => undef,
'wield color' => undef,