diegonehab/luasocket
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Don't swallow errors in finalizers.

Browse Source
This commit is contained in:
Philipp Janda 2016-02-24 00:48:43 +01:00
parent 9ffd96724d
commit 9fe38c654f
3 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
doc/socket.html
View File

@ -167,8 +167,7 @@ is raised.
<p class=parameters> <p class=parameters>
<tt>Finalizer</tt> is a function that will be called before <tt>Finalizer</tt> is a function that will be called before
<tt>try</tt> throws the exception. It will be called <tt>try</tt> throws the exception.
in <em>protected</em> mode.
</p> </p>
<p class=return> <p class=return>

2
src/except.c
View File

@ -49,7 +49,7 @@ static void wrap(lua_State *L) {
static int finalize(lua_State *L) { static int finalize(lua_State *L) {
if (!lua_toboolean(L, 1)) { if (!lua_toboolean(L, 1)) {
lua_pushvalue(L, lua_upvalueindex(1)); lua_pushvalue(L, lua_upvalueindex(1));
lua_pcall(L, 0, 0, 0); lua_call(L, 0, 0);
lua_settop(L, 2); lua_settop(L, 2);
wrap(L); wrap(L);
lua_error(L); lua_error(L);

1
test/excepttest.lua
View File

@ -5,7 +5,6 @@ local finalizer_called
local func = socket.protect(function(err, ...) local func = socket.protect(function(err, ...)
local try = socket.newtry(function() local try = socket.newtry(function()
finalizer_called = true finalizer_called = true
error("ignored")
end) end)
if err then if err then