14 Commits

Author SHA1 Message Date
Ville Skyttä
885e6dd6b6 Drop internal uses of $default, $filenames and friends.
Definitions are still present though, tentatively scheduled for
removal as of 2.0.
2009-10-22 12:04:29 +03:00
Ville Skyttä
474896f2c8 Speed up installed rpm package completion on SUSE (Alioth: #312021). 2009-10-20 22:47:31 +03:00
Guillaume Rousse
506e1cb3eb new indentation policy 2009-10-04 19:42:50 +02:00
Ville Skyttä
369980bf93 Tell *Emacs to indent comments (sh-indent-comment: t).
Also move indentation settings to end of files and expand *Emacs ones to
local variables block to avoid overflowing 80 char lines.
2009-10-01 20:54:51 +03:00
Ville Skyttä
a7fb763fdd Remove unused ver variable, thanks to Elan Ruusamäe. 2009-09-29 20:41:14 +03:00
Ville Skyttä
9322da7992 Add more common options to rpm option completions. 2009-09-29 20:37:42 +03:00
Ville Skyttä
1453625e50 Prevent rpm --define/-D completions from falling through. 2009-09-27 10:18:43 +03:00
Freddy Vulto
cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00
Ville Skyttä
8770727a08 Add xz and compress support to rpmbuild -t*/--tarbuild completion. 2009-08-26 23:58:50 +03:00
Ville Skyttä
2bef79059c Add more tarball filename extensions to rpmbuild -t*/--tarbuild completion. 2009-08-26 23:55:28 +03:00
Ville Skyttä
c6360dde51 Trim trailing whitespace (cosmetic, no functional changes). 2009-07-25 13:38:42 +03:00
Ville Skyttä
2e641b5c6f Improve rpm group completion.
Displayed completions are still wrong but now at least real ones containing
spaces do work and unusual input does not cause grep errors.
http://lists.alioth.debian.org/pipermail/bash-completion-devel/2009-May/001486.html
2009-06-09 00:13:20 +03:00
Ville Skyttä
4ad2698236 Add indentation settings. 2009-06-06 00:48:22 +03:00
David Paleino
34d7032b12 Split rpm-related completions to contrib/rpm 2009-06-05 08:40:33 +02:00