9 Commits

Author SHA1 Message Date
Freddy Vulto
cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00
Ville Skyttä
e7c3bbe23c Add missing 'have foo's. 2009-06-08 21:22:43 +03:00
David Paleino
fe04d9dedf Use proper options variables 2009-02-05 10:11:24 +01:00
Ville Skyttä
4a360233d2 Do not make vi and friends expand tabs with spaces. 2009-01-17 11:38:33 +02:00
Ville Skyttä
0a8174b77a Remove obsolete CVS $Id$ keywords. 2009-01-14 22:24:51 +02:00
Ville Skyttä
c353789983 Add/compact *Emacs, vi and friends indentation etc settings. 2009-01-14 22:17:14 +02:00
David Paleino
9cbd3ceab2 - add more completions to aptitude (Closes: #432289)
- fixed UTF-8 problem with _get_cword(), thanks to
    Andrei Paskevich (Closes: #472132)
  - fixed autoremove completion, thanks to Flavio Visentin
    (Closes: #474974)
  - cmf and CMF added to playmidi completion (Closes: #365658)
  - added rrdtool completion, thanks to Justin Pryzby (Closes: #428641)
  - added OpenDocument completion for unzip/zipinfo (.od{f,g,p,s,t})
    (Closes: #472940)
2008-05-10 18:04:06 +02:00
ianmacd
195bb6afb7 - add CVS tags 2004-03-30 21:05:45 +00:00
ianmacd
32a3e243bf - Lisp completions by Nikodemus Siivola <tsiivola@cc.hut.fi> 2004-03-30 18:56:02 +00:00