18 Commits

Author SHA1 Message Date
Ville Skyttä
2a5a1d68d9 Fix some syntax errors.
For some reason, these constructs got flagged as syntax errors at load
time with bash 4.0.33(0)-release on FreeBSD 8.0 whereas they work
elsewhere I've tested (e.g. 4.0.23(1)-release on Fedora Core 11).
2010-01-03 21:18:41 +02:00
Guillaume Rousse
f2041ce0e4 no need to quote case argument nor targets 2009-12-30 00:39:59 +01:00
Ville Skyttä
76383dd49d Just use _known_hosts directly for generic vncviewer. 2009-12-26 14:11:49 +02:00
Ville Skyttä
2c475419b7 Install known hosts only completion for generic vncviewer.
For example Fedora uses tigervnc without symlinks from which it could
be recognized, and neither tightvncviewer nor xvnc4viewer completions
seem quite appropriate for it at the moment.
2009-12-26 13:32:57 +02:00
Ville Skyttä
878b9a3e99 Define _tightvncviewer also when (only) vncviewer is available. 2009-12-25 12:14:10 +02:00
Ville Skyttä
cffa2db149 Fix comment spelling and line wrapping. 2009-12-25 12:07:47 +02:00
Ville Skyttä
8ab6708302 Drop dead code.
Availability of vncviewer is already checked with "have".
2009-12-25 12:05:44 +02:00
Ville Skyttä
6807b5e72d Replace some echos with printfs. 2009-12-21 00:09:02 +02:00
Ville Skyttä
8caddc47cf Protect grep invocations from user aliases (Alioth: 312143). 2009-12-15 23:48:10 +02:00
Ville Skyttä
04b7883f7d Use here strings instead of echos where appropriate (part of Alioth: #312143). 2009-12-09 22:46:09 +02:00
Guillaume Rousse
506e1cb3eb new indentation policy 2009-10-04 19:42:50 +02:00
Ville Skyttä
369980bf93 Tell *Emacs to indent comments (sh-indent-comment: t).
Also move indentation settings to end of files and expand *Emacs ones to
local variables block to avoid overflowing 80 char lines.
2009-10-01 20:54:51 +03:00
Freddy Vulto
cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00
Ville Skyttä
c6360dde51 Trim trailing whitespace (cosmetic, no functional changes). 2009-07-25 13:38:42 +03:00
Freddy Vulto
25e4eb6df3 Gave _known_hosts_real mandatory argument CWORD
The option `-h hostname' to `_known_hosts_real' is removed.
2009-07-03 22:28:13 +02:00
Freddy Vulto
0b19577ed9 Added -h HOST option to _known_hosts_real
Modified call to _known_hosts_real in ssh, vncviewer and xhost completions.
2009-06-13 08:38:52 +02:00
Ville Skyttä
e7c3bbe23c Add missing 'have foo's. 2009-06-08 21:22:43 +03:00
Freddy Vulto
23ff82046f Improved vncviewer completion
- Split vncviewer completion in _tightvncviewer() and _xvn4viewer()
    - Vncviewer completion automatically selects right completion at
      run-time.  Default is _tightvncviewer().
    - Added _realcommand() global function
2009-03-16 21:57:12 +01:00