14 Commits

Author SHA1 Message Date
David Paleino
8f42adfa8d Style policy: don't use fancy globbing in case labels 2009-11-22 11:43:26 +01:00
Ville Skyttä
29ee9fb3f9 Use _available_interfaces in route dev completion. 2009-10-31 14:08:43 +02:00
Ville Skyttä
50b4b8459f route(1) completion code cleanups. 2009-10-31 14:01:26 +02:00
Ville Skyttä
774d50a9c9 Install _route completion only when route is available, remove unneeded $UNAME test. 2009-10-31 13:59:41 +02:00
Ville Skyttä
885e6dd6b6 Drop internal uses of $default, $filenames and friends.
Definitions are still present though, tentatively scheduled for
removal as of 2.0.
2009-10-22 12:04:29 +03:00
Ville Skyttä
2c83f0ff43 Remove many unnecessary short option completions where long ones exist. 2009-10-18 22:12:37 +03:00
Guillaume Rousse
506e1cb3eb new indentation policy 2009-10-04 19:42:50 +02:00
Ville Skyttä
369980bf93 Tell *Emacs to indent comments (sh-indent-comment: t).
Also move indentation settings to end of files and expand *Emacs ones to
local variables block to avoid overflowing 80 char lines.
2009-10-01 20:54:51 +03:00
Freddy Vulto
cfcf9fae8f Quote unquoted $cur to prevent globbing.
Closes Alioth #311614

Globbing might occur if $cur contains one of these globbing characters: * ? [ ]

The bug becomes apparent:

On Cygwin if the glob-string contains backslashes as well, causing a warning (Cygwin >= 1.7):

    MS-DOS style path detected: ...
    Preferred POSIX equivalent is: ...
    CYGWIN environment variable option "nodosfilewarning" turns off this warning.
    Consult the user's guide for more details about POSIX paths:
      http://cygwin.com/cygwin-ug-net/using.html#using-pathnames

On Linux, using strace, you can see bash-completion doing an unnecessary `open' system call.

Steps to reproduce on Linux using `strace':

Environment:  Linux, bash-completion-1.0

1.  Start bash with bash-completion loaded and find out PID ($$):

    $ echo $$
    MYPID

2.  In a second bash shell, `strace' the above PID:

    $ strace -e trace=open -f -o strace.log -p MYPID

3.  Within the first bash shell, type:

    $ cur="?"; _kernel_versions

4.  In the second bash shell, type ^C to quick `strace'.

5.  Check `strace.log', here you can see bash accessing
    something it shouldn't:

    ...
    open(".", O_RDONLY|O_NONBLOCK|O_LARGEFILE|O_DIRECTORY|O_CLOEXEC) = 3
    ...

6.  The above call to `open' disappears if $cur in _kernel_versions gets
    quoted, and you repeat the steps above:

    _kernel_versions()
    {
        COMPREPLY=( $( compgen -W '$( command ls /lib/modules )' -- "$cur" ) )
    }
2009-09-25 09:36:29 +02:00
Guillaume Rousse
7f83cb5816 split route completion 2009-06-08 16:51:17 +02:00
Ville Skyttä
9a63f2983d Use _split_longopt in mii-diag and mii-tool. 2009-05-13 00:06:40 +03:00
Freddy Vulto
0ebd5edd3b Make _mii-tool()' & _mii-diag()' POSIX-compliant
Dash (-) is replaced with underscore (_).  This prevents errors when
bash-completion is loaded while `set -o posix' is active:

    bash: `_mii-tool': not a valid identifier
    bash: `_mii-diag': not a valid identifier
2009-02-22 11:48:49 +01:00
David Paleino
fe04d9dedf Use proper options variables 2009-02-05 10:11:24 +01:00
David Paleino
7058a9b442 Added net-tools (mii-tool and mii-diag) completions 2009-02-05 09:48:44 +01:00