csonto/bash-completion
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid sourcing dirs in completion loader to avoid fd leaks (RedHat: #903540).

Browse Source
This commit is contained in:
Ville Skyttä 2013-01-25 00:06:34 +02:00
parent 2eeffeea7a
commit fea1c178b4
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
bash_completion
View File

@ -1918,11 +1918,12 @@ complete -F _minimal ''
# set up dynamic completion loading # set up dynamic completion loading
_completion_loader() _completion_loader()
{ {
local compdir=./completions local compfile=./completions
[[ $BASH_SOURCE == */* ]] && compdir="${BASH_SOURCE%/*}/completions" [[ $BASH_SOURCE == */* ]] && compfile="${BASH_SOURCE%/*}/completions"
compfile+="${1##*/}"
# Try basename. # Avoid trying to source dirs; https://bugzilla.redhat.com/903540
. "$compdir/${1##*/}" &>/dev/null && return 124 [[ -f "$compfile" ]] && . "$compfile" &>/dev/null && return 124
# Need to define *something*, otherwise there will be no completion at all. # Need to define *something*, otherwise there will be no completion at all.
complete -F _minimal "$1" && return 124 complete -F _minimal "$1" && return 124