csonto/bash-completion
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove eval() and sed quoting in _known_hosts() (Alioth: #311595)

Browse Source 
Fixes execution (!!!) of hosts specified by {Global,User}KnownHosts
    in SSH config files.
This commit is contained in:
David Paleino 2009-04-13 17:10:41 +02:00
parent a17930f8dd
commit a9994ac15f
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@ -2,6 +2,9 @@ bash-completion (1.x)
[ David Paleino ] [ David Paleino ]
* Permit .gz files concatenation (Debian: #514377) * Permit .gz files concatenation (Debian: #514377)
* Remove eval() and sed quoting in _known_hosts(), fixes execution (!!!)
of hosts specified by {Global,User}KnownHosts in SSH config files
(Alioth: #311595)
[ Ville Skyttä ] [ Ville Skyttä ]
* Split yum and yum-arch completion into contrib/yum. * Split yum and yum-arch completion into contrib/yum.

4
bash_completion
View File

@ -2680,9 +2680,9 @@ _known_hosts()
if [ ${#config[@]} -gt 0 ]; then if [ ${#config[@]} -gt 0 ]; then
# expand path (if present) to global known hosts file # expand path (if present) to global known hosts file
global_kh=$( eval echo "$( sed -ne 's/^[ \t]*[Gg][Ll][Oo][Bb][Aa][Ll][Kk][Nn][Oo][Ww][Nn][Hh][Oo][Ss][Tt][Ss][Ff][Ii][Ll][Ee]['"$'\t '"']*\(.*\)$/\1/p' "${config[@]}" )" ) global_kh=$( echo $( sed -ne 's/^[ \t]*[Gg][Ll][Oo][Bb][Aa][Ll][Kk][Nn][Oo][Ww][Nn][Hh][Oo][Ss][Tt][Ss][Ff][Ii][Ll][Ee]['"$'\t '"']*\(.*\)$/\1/p' "${config[@]}" ) )
# expand path (if present) to user known hosts file # expand path (if present) to user known hosts file
user_kh=$( eval echo "$( sed -ne 's/^[ \t]*[Uu][Ss][Ee][Rr][Kk][Nn][Oo][Ww][Nn][Hh][Oo][Ss][Tt][Ss][Ff][Ii][Ll][Ee]['"$'\t '"']*\(.*\)$/\1/p' "${config[@]}" )" ) user_kh=$( echo $( sed -ne 's/^[ \t]*[Uu][Ss][Ee][Rr][Kk][Nn][Oo][Ww][Nn][Hh][Oo][Ss][Tt][Ss][Ff][Ii][Ll][Ee]['"$'\t '"']*\(.*\)$/\1/p' "${config[@]}" ) )
fi fi
# Global known_hosts files # Global known_hosts files