csonto/bash-completion
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

_completion_loader: Use _minimal instead of _longopt as fallback.

Browse Source 
_longopt may end up invoking the completed command with --help which
may not be safe for all arbitrary commands out there.
This commit is contained in:
Ville Skyttä 2011-10-23 11:32:13 +03:00
parent f6cd9344fb
commit 8fe4a73f9a
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
bash_completion
View File

@ -1817,6 +1817,15 @@ _install_xspec '!@(*.@(ks|jks|jceks|p12|pfx|bks|ubr|gkr|cer|crt|cert|p7b|pkipath
_install_xspec '!*.@(mp[234c]|og[ag]|@(fl|a)ac|m4[abp]|spx|tta|w?(a)v|wma|aif?(f)|asf|ape)' kid3 kid3-qt _install_xspec '!*.@(mp[234c]|og[ag]|@(fl|a)ac|m4[abp]|spx|tta|w?(a)v|wma|aif?(f)|asf|ape)' kid3 kid3-qt
unset -f _install_xspec unset -f _install_xspec
# Minimal completion to use as fallback in _completion_loader.
_minimal()
{
local cur prev words cword split
_init_completion -s || return
$split && return
_filedir
}
# set up dynamic completion loading # set up dynamic completion loading
_completion_loader() _completion_loader()
{ {
@ -1837,7 +1846,7 @@ _completion_loader()
. "$compdir/${1##*/}" &>/dev/null && return 124 . "$compdir/${1##*/}" &>/dev/null && return 124
# Need to define *something*, otherwise there will be no completion at all. # Need to define *something*, otherwise there will be no completion at all.
complete -F _longopt "$1" && return 124 complete -F _minimal "$1" && return 124
} && } &&
complete -D -F _completion_loader complete -D -F _completion_loader