Reviewed tests h* & i*

Localized `i' variable in `info' completion.

contrib/info

@@ -6,7 +6,7 @@
 have info &&
 _info()
 {
-	local cur infopath
+	local cur i infopath
 
 	COMPREPLY=()
 	cur=`_get_cword`

test/_completion_to_review/head.exp

@@ -1 +0,0 @@
-source "lib/completions/head.exp"

test/_completion_to_review/hg.exp

@@ -1 +0,0 @@
-source "lib/completions/hg.exp"

test/_completion_to_review/iconv.exp

@@ -1 +0,0 @@
-source "lib/completions/iconv.exp"

test/_completion_to_review/id.exp

@@ -1 +0,0 @@
-source "lib/completions/id.exp"

test/_completion_to_review/identify.exp

@@ -1 +0,0 @@
-source "lib/completions/identify.exp"

test/_completion_to_review/ifdown.exp

@@ -1 +0,0 @@
-source "lib/completions/ifdown.exp"

test/_completion_to_review/ifup.exp

@@ -1 +0,0 @@
-source "lib/completions/ifup.exp"

test/_completion_to_review/indent.exp

@@ -1 +0,0 @@
-source "lib/completions/indent.exp"

test/_completion_to_review/info.exp

@@ -1 +0,0 @@
-source "lib/completions/info.exp"

test/_completion_to_review/inject.exp

@@ -1 +0,0 @@
-source "lib/completions/inject.exp"

test/_completion_to_review/insmod.exp

@@ -1 +0,0 @@
-source "lib/completions/insmod.exp"

test/_completion_to_review/invoke-rc.d.exp

@@ -1 +0,0 @@
-source "lib/completions/invoke-rc.d.exp"

test/_completion_to_review/irb.exp

@@ -1 +0,0 @@
-source "lib/completions/irb.exp"

test/_completion_to_review/isql.exp

@@ -1 +0,0 @@
-source "lib/completions/isql.exp"

test/completion/head.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {head}]} {
+    source "lib/completions/head.exp"
+}; # if

test/completion/iconv.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {iconv}]} {
+    source "lib/completions/iconv.exp"
+}; # if

test/completion/id.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {id}]} {
+    source "lib/completions/id.exp"
+}; # if

test/completion/identify.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {convert}]} {
+    source "lib/completions/identify.exp"
+}; # if

test/completion/ifdown.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {ifdown}]} {
+    source "lib/completions/ifdown.exp"
+}; # if

test/completion/ifup.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {ifup}]} {
+    source "lib/completions/ifup.exp"
+}; # if

test/completion/indent.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {indent}]} {
+    source "lib/completions/indent.exp"
+}; # if

test/completion/info.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {info}]} {
+    source "lib/completions/info.exp"
+}; # if

test/completion/inject.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {inject}]} {
+    source "lib/completions/inject.exp"
+}; # if

test/completion/insmod.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {insmod}]} {
+    source "lib/completions/insmod.exp"
+}; # if

test/completion/invoke-rc.d.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {invoke-rc.d}]} {
+    source "lib/completions/invoke-rc.d.exp"
+}; # if

test/completion/irb.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {irb}]} {
+    source "lib/completions/irb.exp"
+}; # if

test/completion/isql.exp

@@ -0,0 +1,3 @@
+if {[assert_bash_type {isql}]} {
+    source "lib/completions/isql.exp"
+}; # if

test/fixtures/isql/odbc.ini

@@ -0,0 +1,3 @@
+[foo]
+
+[bar]

test/lib/completions/head.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "head --"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/iconv.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "iconv "
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/id.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "id -"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/identify.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "identify -"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/ifdown.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "ifdown "
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/ifup.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "ifup "
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/indent.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "indent --"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/info.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "info "
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/inject.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "inject "
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/insmod.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "insmod in"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/invoke-rc.d.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "invoke-rc.d "
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/irb.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "irb "
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/isql.exp

@@ -0,0 +1,23 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified {/ODBCINI=/d}
+}; # teardown()
+
+
+setup
+
+
+assert_bash_exec {OLDODBCINI=$ODBCINI; ODBCINI=$TESTDIR/fixtures/isql/odbc.ini}
+assert_complete_any "isql "
+sync_after_int
+assert_bash_exec {ODBCINI=$OLDODBCINI; unset -v OLDODBCINI}
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/iwconfig.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "iwconfig --"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/iwlist.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "iwlist --"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/iwpriv.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_complete_any "iwpriv --"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions/iwspy.exp

@@ -0,0 +1,20 @@
+proc setup {} {
+    save_env
+}; # setup()
+
+
+proc teardown {} {
+    assert_env_unmodified
+}; # teardown()
+
+
+setup
+
+
+assert_env_unmodified "iwspy --"
+
+
+sync_after_int
+
+
+teardown

test/lib/completions_to_review/head.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "head "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/hg.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "hg -R "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/iconv.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "iconv "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/id.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "id "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/identify.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "identify "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/ifdown.exp

@@ -1,27 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "ifdown "
-send "$cmd\t"
-expect {
-    -re "^$cmd.*$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sleep .5
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/ifup.exp

@@ -1,44 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should show completions"
-    # Try completion
-set cmd "ifup "
-send "$cmd\t"
-expect {
-    -re "^$cmd.*\r\n/@$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-set test "Argument should complete"
-    # Set test function for _configured_interfaces()
-set cmd "_configured_interfaces() { COMPREPLY=( foo bar ); }"
-send "$cmd\r"
-expect -ex "$cmd\r\n/@"
-    # Try completion
-set cmd "ifup f"
-send "$cmd\t"
-expect {
-    -re "^${cmd}oo\\s*$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/indent.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "indent "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/info.exp

@@ -1,31 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "info "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-# Interrupt command
-
-set test "Sync after QUIT/INT"
-sleep 0.01
-send \031\003
-expect -ex /@
-
-
-teardown

test/lib/completions_to_review/inject.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "inject "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/insmod.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should show completions"
-    # Try completion
-set cmd "insmod in"
-send "$cmd\t"
-expect {
-    -re "$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/invoke-rc.d.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "invoke-rc.d "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/irb.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "irb "
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/isql.exp

@@ -1,34 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should show completions"
-    # Try completion
-set cmd "isql "
-send "$cmd\t"
-expect {
-	# TODO: If $ODBCINI is set, match completions
-	#       -- FVu, Fri Feb 27 22:58:05 CET 2009
-    -re "^$cmd.*" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-    # Because we don't wait for prompt (/@), wait a moment
-    # for `comp_load' to install real completion.  This can
-    # be removed if the TODO above is fixed.
-    # -- FVu, Fri Feb 27 23:14:49 CET 2009
-sleep .5
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/iwconfig.exp

@@ -1,40 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "iwconfig --"
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-set test "Tab should not complain about _available_interfaces() not being available"
-    # Try completion
-set cmd "iwconfig #"
-send "$cmd\t"
-expect {
-    -re "^$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/iwlist.exp

@@ -1,31 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "iwlist --"
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-# Interrupt command
-
-set test "Sync after INT"
-sleep 0.01
-send \031\003;  # QUIT/INT
-expect -ex /@
-
-
-teardown

test/lib/completions_to_review/iwpriv.exp

@@ -1,26 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "iwpriv --"
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-sync_after_int
-
-
-teardown

test/lib/completions_to_review/iwspy.exp

@@ -1,31 +0,0 @@
-proc setup {} {
-}; # setup()
-
-
-proc teardown {} {
-}; # teardown()
-
-
-setup
-
-
-set test "Tab should complete"
-    # Try completion
-set cmd "iwspy --"
-send "$cmd\t"
-expect {
-    -re "^$cmd\r\n.*$cmd$" { pass "$test" }
-    -re /@ { unresolved "$test at prompt" }
-    -re eof { unresolved "eof" }
-}; # expect
-
-
-# Interrupt command
-
-set test "Sync after QUIT/INT"
-sleep 0.01
-send \031\003;  # QUIT/INT
-expect -ex /@
-
-
-teardown

test/lib/library.exp

@@ -134,13 +134,23 @@ proc assert_complete_any {cmd {test ""} {prompt /@}} {
         # Escape special regexp characters
     regsub -all {([\[\]\(\)\.\\\+])} $cmd {\\\1} cmd
     expect {
+        -timeout 1
+        # Match completions, multiple words
         # NOTE: The `\S*' (zero or more non-whitespace characters) matches a
-        #       possible enlargement of a command's partial completion if the
+        #       longest common prefix of the completions shown.
-        #       list of completions have a larger common prefix.
         #       E.g. `fmt -' becomes `fmt --' (two dashes) when completing
         -re "^\r\n.*$prompt$cmd\\S*$" { pass "$test" }
+        timeout {
+            expect {
+                # Match completion, single word.  This word is shown on the
+                # same line as the command.
+                -re "^\\w+ $" { pass "$test" }
+                # Try matching multiple words again, with new timeout
+                -re "^\r\n.*$prompt$cmd\\S*$" { pass "$test" }
+            }
+        }
         -re $prompt { unresolved "$test at prompt" }
-        -re eof { unresolved "eof" }
+        eof { unresolved "eof" }
     }; # expect
 }; # assert_complete_any()