celeron55/buildat
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

server/state: Improve access dependency check

Browse Source
This commit is contained in:
Perttu Ahola 2014-10-27 23:44:10 +02:00
parent bf8d2b8dec
commit c0d87faab0
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/server/state.cpp
View File

@ -757,11 +757,16 @@ struct CState: public State, public interface::Server
throw Exception("Cannot access \""+target_name+"\" from \""+ throw Exception("Cannot access \""+target_name+"\" from \""+
caller_name+"\": Accessing itself is disallowed"); caller_name+"\": Accessing itself is disallowed");
// Access is invalid if target is being accessed by somebody who is // Access is invalid if caller is a direct or indirect dependency of
// being accessed by caller, directly or indirectly // target
if(!is_dependency_u(caller_mc, target_mc)) if(is_dependency_u(target_mc, caller_mc))
throw Exception("Cannot access \""+target_name+"\" from \""+ throw Exception("Cannot access \""+target_name+"\" from \""+
caller_name+"\": Not a dependency"); caller_name+"\": Target depends on caller - access must "
"happen the other way around");
// The thing we are trying to disallow is that if module 1 accesses
// module 2 at some point, then at no point shall module 2 be allowed to
// access module 1.
// Access is valid // Access is valid
} }