Patch mod away

ea80cdeedd

README.md

@@ -705,7 +705,7 @@ The game includes the mods from the default [minetest_game](https://github.com/m
 [patch.airtanks]: https://github.com/AntumMT/mod-airtanks/tree/8b7fd12
 [patch.amber]: https://github.com/AntumMT/mod-amber/tree/39b852a
 [patch.atm]: https://github.com/AntumMT/mod-atm/tree/2ab0e78
-[patch.away]: https://github.com/AntumMT/mod-away/tree/3b0bf9e
+[patch.away]: https://github.com/AntumMT/mod-away/tree/ea80cdeeddd5f25526d3f1bc506f5bfa4c7fee0a
 [patch.bags]: https://github.com/AntumMT/mod-bags/tree/db216eebc2e63a68061d9f865f649c0ae3490bdd
 [patch.beds]: https://github.com/AntumMT/mod-beds/commit/88155ca
 [patch.boats2]: https://github.com/AntumMT/mod-boats2/tree/9b2bcb7

mods/chat/away/README.md

@@ -0,0 +1,27 @@
+
+# Away Command
+
+## About
+
+A simple [Luanti (Minetest)](https://luanti.org/) mod that adds an `/away` command. Inspired by jordan4ibanez's extra commands mod, but works slightly differently than its `/afk` command.
+
+## Usage
+
+- `/away [reason]`: If you are not marked as away or a reason parameter is given, marks you as away (or changes the away reason). If you are marked as away and no reason parameter is given, sets you as not away and possibly notifies other players (if they tried to talk to you while you were away).
+- `/away? [name]`: Checks the away status of the player with the specified name, or yourself if no name parameter is given. Possible statuses are: present, away (<reason>), disconnected.
+
+`/away <reason>` marks you as being away. The reason is optional. When you're back, simply type `/away` again. Writing a chat message (except commands) clears your away status too. You can check your away status with the command `/away?`, and that of other people with `/away? <name>`.
+
+Other players don't immediately see when you set yourself as away, unless they constantly watch you with `/away? yourname`. However, when somebody mentions your name in chat, they receive an away notice. If that happens, they're also notified as soon as you come back. The intent of this delayed notice system is to reduce away message spam.
+
+## Notes
+
+- No dependencies. Should be compatible with almost all other mods, if an incompatibility is found I'll list it here.
+- If the name of an away player is mentioned multiple times in succession, only one notice is printed per minute.
+- Players without the shout privilege can not set a reason in `/away`.
+- Away statuses are not persistent, as that would make no sense. They're cleared when the server quits or the player disconnects (but see "Bugs" below).
+
+## Bugs
+
+- Moving around or interacting with things should probably reset the away status. Ideally this should be configurable.
+- Away statuses are not immediately reset when a player disconnects. If the player was marked away and reconnects within 1-2 minutes after disconnecting, he may still be marked away. (Problem: there's no register_on_disconnect callback.)

mods/chat/away/depends.txt

@@ -1 +0,0 @@
-default

mods/chat/away/init.lua

@@ -71,7 +71,7 @@ end
 function get_away_reason(name)
 	-- If a player's shout privilege has been revoked,
 	-- others shouldn't see the away reason
-	if is_away(name) and minetest.get_player_privs(name)['shout'] then
+	if is_away(name) and core.get_player_privs(name)['shout'] then
 		return away_reasons[name]
 	else
 		return ''
@@ -80,10 +80,10 @@ end
 
 function set_away(name, reason)
 	if is_away(name) then
-		minetest.chat_send_player(name, "You are still marked as away (away reason updated)")
+		core.chat_send_player(name, "You are still marked as away (away reason updated)")
 		away_reasons[name] = reason
 	else
-		minetest.chat_send_player(name, "You are now marked as away")
+		core.chat_send_player(name, "You are now marked as away")
 		away_players[name] = true
 		away_reasons[name] = reason
 		away_last_inform[name] = nil
@@ -95,7 +95,7 @@ function unset_away(name)
 		if away_last_inform[name] ~= nil then
 			table.insert(away_inform_outbox, name .. " is no longer away")
 		else
-			minetest.chat_send_player(name, "You are no longer marked as away")
+			core.chat_send_player(name, "You are no longer marked as away")
 		end
 		away_players[name] = nil
 		away_reasons[name] = nil
@@ -113,7 +113,7 @@ end
 
 -- Returns 'present' or 'away' or 'away (<reason>)' or 'disconnected'
 function get_away_status(name)
-	if minetest.get_player_by_name(name) == nil then
+	if core.get_player_by_name(name) == nil then
 		return 'disconnected'
 	elseif is_away(name) then
 		reason = get_away_reason(name)
@@ -128,7 +128,7 @@ function get_away_status(name)
 end
 
 
-minetest.register_on_chat_message(function(name, message)
+core.register_on_chat_message(function(name, message)
 	local cmd
 
 	cmd = AWAYP_COMMAND
@@ -137,10 +137,10 @@ minetest.register_on_chat_message(function(name, message)
 		local name2 = string.match(message, cmd:gsub("?", "[?]").." (.*)")
 		if name2 == nil or name2 == '' or name2 == name then
 			name2 = name
-			minetest.chat_send_player(name,
+			core.chat_send_player(name,
 				"Your status: " .. get_away_status(name2))
 		else
-			minetest.chat_send_player(name,
+			core.chat_send_player(name,
 				name2 .. "'s status: " .. get_away_status(name2))
 		end
 		return true -- Handled chat message
@@ -159,7 +159,7 @@ minetest.register_on_chat_message(function(name, message)
 
 	if message:sub(1, 1) ~= '/' then
 		-- Normal chat message (not a command)
-		if not minetest.get_player_privs(name)['shout'] then
+		if not core.get_player_privs(name)['shout'] then
 			-- Ignore if player has no shout privilege
 			return false -- Continue normal processing
 		end
@@ -192,13 +192,13 @@ minetest.register_on_chat_message(function(name, message)
 end)
 
 local away_check_disconnect_timer = 0
-minetest.register_globalstep(function(dtime)
+core.register_globalstep(function(dtime)
 	away_check_disconnect_timer = away_check_disconnect_timer + dtime
 	if away_check_disconnect_timer >= AWAY_CHECK_DISCONNECT_INTERVAL then
 		away_check_disconnect_timer = 0
 		local disconnected = {}
 		for name, _ in pairs(away_players) do
-			if minetest.get_player_by_name(name) == nil then
+			if core.get_player_by_name(name) == nil then
 				table.insert(disconnected, name)
 			end
 		end
@@ -211,7 +211,7 @@ minetest.register_globalstep(function(dtime)
 
 	if #away_inform_outbox ~= 0 then
 		for _, message in ipairs(away_inform_outbox) do
-			minetest.chat_send_all("Server: " .. message)
+			core.chat_send_all("Server: " .. message)
 		end
 		away_inform_outbox = {}
 	end

mods/chat/away/mod.conf

@@ -0,0 +1,4 @@
+name = away
+title = Away Command
+description = Adds an /away command.
+version = 1.0