Zylann/godot_voxel
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Avoid creating ArrayMesh instance if empty

Browse Source
This commit is contained in:
Marc Gilleron 2022-03-15 00:17:42 +00:00
parent 7277a6a79f
commit 646618e78a
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
terrain/voxel_lod_terrain.cpp
View File

@ -25,7 +25,6 @@ Ref<ArrayMesh> build_mesh(
Span<const Array> surfaces, Mesh::PrimitiveType primitive, int flags, Ref<Material> material) {
VOXEL_PROFILE_SCOPE();
Ref<ArrayMesh> mesh;
mesh.instantiate();
unsigned int surface_index = 0;
for (unsigned int i = 0; i < surfaces.size(); ++i) {
@ -40,6 +39,10 @@ Ref<ArrayMesh> build_mesh(
continue;
}
if (mesh.is_null()) {
mesh.instantiate();
}
// TODO Use `add_surface`, it's about 20% faster after measuring in Tracy (though we may see if Godot 4 expects
// the same)
mesh->add_surface_from_arrays(primitive, surface, Array(), Dictionary(), flags);