XQF/xqf
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix memory leak in source.c:init_masters, remove FIXME

Browse Source 
git-svn-id: http://svn.code.sf.net/p/xqf/code/trunk@260 d2ac09be-c843-0410-8b1f-f8a84130e0ec
This commit is contained in:
Bill Adams 2002-10-18 02:48:27 +00:00 committed by evilbill
parent aba6761a26
commit 264cd4504e
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
xqf/ChangeLog
View File

@ -1,3 +1,6 @@
Oct 17, 2002: Bill Adams <nospam-200201@evilbill.org>
- Fixed init_masters to not have a memory leak.
Oct 16, 2002: Alex Burger <alex@users.sourceforge dot net>
- Created server_list_prepend_ndp which does not check for duplicates.
Modified master_add_server to use server_list_prepend_ndp. Modified

10
xqf/src/source.c
View File

@ -792,6 +792,7 @@ struct master *add_master (char *path, char *name, enum server_type type,
#if 0
{ /* for xemacs so it does not loose its mind -- baa */
if (g_strncasecmp (path, master_prefixes[MASTER_NATIVE],
strlen(master_prefixes[MASTER_NATIVE])) == 0) {
if (parse_address (path + strlen(master_prefixes[MASTER_NATIVE]), &addr, &port)) {
@ -1308,10 +1309,9 @@ void init_masters (int update) {
if (m2 && m2->servers)
m2->servers = g_slist_sort (m2->servers, (GCompareFunc) server_sorting_helper);
//FIXME: Is this right? I tried g_slist_free, but it sits there for a long time.
if (list3)
list3 = NULL;
s1 = NULL;
s2 = NULL;
@ -1336,8 +1336,8 @@ void init_masters (int update) {
list2 = list2->next;
continue;
}
list3 = g_slist_prepend (list3, s1);
g_free (temp1);
g_free (temp2);
}
@ -1349,8 +1349,10 @@ void init_masters (int update) {
list2 = list2->next;
}
if (list3)
if (list3) {
g_slist_free (m2->servers);
m2->servers = list3;
}
}
read_server_info (FILENAME_SRVINFO);