Make sure color returns to normal after a damage flash (#7332)

src/content_cao.cpp

@@ -990,7 +990,7 @@ void GenericCAO::updateTexturePos()
 	}
 }
 
-void GenericCAO::updateTextures(const std::string &mod)
+void GenericCAO::updateTextures(std::string mod)
 {
 	ITextureSource *tsrc = m_client->tsrc();
 

src/content_cao.h

@@ -198,8 +198,8 @@ public:
 	void updateTexturePos();
 
 	// std::string copy is mandatory as mod can be a class member and there is a swap
-	// on those class members
-	void updateTextures(const std::string &mod);
+	// on those class members... do NOT pass by reference
+	void updateTextures(std::string mod);
 
 	void updateAnimation();