Mineclonia/mineclonia-cd2025
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only read once from minetest.registered_nodes for piston push

Browse Source
This commit is contained in:
cora 2024-11-23 23:35:51 +01:00 committed by ryvnf
parent 3e739cc380
commit 9d203222c9
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
mods/ITEMS/REDSTONE/mcl_pistons/api.lua
View File

@ -51,9 +51,10 @@ function mcl_pistons.push(pos, movedir, maximum, player_name, piston_pos)
nn = minetest.get_node(np) nn = minetest.get_node(np)
end end
local def = minetest.registered_nodes[nn.name]
if minetest.get_item_group(nn.name, "unmovable_by_piston") == 1 if minetest.get_item_group(nn.name, "unmovable_by_piston") == 1
or (not inv_nodes_movable and minetest.get_item_group(nn.name, "container") ~= 0) or (not inv_nodes_movable and minetest.get_item_group(nn.name, "container") ~= 0)
or not minetest.registered_nodes[nn.name] then or not def then
return return
end end
@ -65,7 +66,7 @@ function mcl_pistons.push(pos, movedir, maximum, player_name, piston_pos)
-- if we want the node to drop, e.g. sugar cane, do not count towards push limit -- if we want the node to drop, e.g. sugar cane, do not count towards push limit
table.insert(dig_nodes, {node = nn, pos = vector.add(np, movedir), old_pos = vector.copy(np)}) table.insert(dig_nodes, {node = nn, pos = vector.add(np, movedir), old_pos = vector.copy(np)})
else else
if not minetest.registered_nodes[nn.name].buildable_to then if not def.buildable_to then
table.insert(nodes, {node = nn, pos = vector.add(np, movedir), old_pos = vector.copy(np)}) table.insert(nodes, {node = nn, pos = vector.add(np, movedir), old_pos = vector.copy(np)})
if #nodes > maximum then if #nodes > maximum then
return return
@ -75,12 +76,12 @@ function mcl_pistons.push(pos, movedir, maximum, player_name, piston_pos)
-- the vectors must be absolute positions -- the vectors must be absolute positions
local connected= {} local connected= {}
local is_connected, offset_node, offset_pos local is_connected, offset_node, offset_pos
if minetest.registered_nodes[nn.name]._mcl_pistons_sticky then if def._mcl_pistons_sticky then
-- when pushing a sticky block, push all applicable blocks with it -- when pushing a sticky block, push all applicable blocks with it
for _, dir in pairs(sixdirs) do for _, dir in pairs(sixdirs) do
offset_pos = np:add(dir:multiply(-1)) offset_pos = np:add(dir:multiply(-1))
offset_node = minetest.get_node(offset_pos) offset_node = minetest.get_node(offset_pos)
is_connected = minetest.registered_nodes[nn.name]._mcl_pistons_sticky(nn, offset_node, dir) is_connected = def._mcl_pistons_sticky(nn, offset_node, dir)
if is_connected and minetest.get_item_group(offset_node.name, "unsticky") == 0 if is_connected and minetest.get_item_group(offset_node.name, "unsticky") == 0
and minetest.get_item_group(offset_node.name, "unmovable_by_piston") == 0 and minetest.get_item_group(offset_node.name, "unmovable_by_piston") == 0