278 Commits

Author SHA1 Message Date
Colomban Wendling
bb61dfcdc3 Add a translation context to the open dialog's "View" button
The "View" button string is the same as the View menu one, but one is
an action (verb) and the other a noun, and as such might need to be
translated differently.
2014-04-15 15:58:04 +02:00
Colomban Wendling
45f193a17a Merge branch 'cleaner-filetype-combo-box' 2014-04-15 15:57:26 +02:00
Colomban Wendling
aeab183ef2 Merge branch 'unified-encoding-combo-boxes' 2014-04-15 15:57:13 +02:00
Colomban Wendling
420891ae81 Group filetypes in the Open dialog filetype combo box
Display the filetypes in the Open dialog filetype combo box grouped,
as they are in the filetypes menu.

This makes it easier to select a filetype, because they are better
sorted and follows the filetypes menu layout.
2014-04-15 15:52:59 +02:00
Colomban Wendling
8c5e198cf1 Unify encoding combo boxes
Make all encoding combo box display a list with encodings grouped by
categories into sub-menus, making it easier to find the appropriate
encoding than in a big single-level list.

This is what was used in the Open dialog, but not in the Preferences
dialog or the Find in Files dialog.  This also makes the encoding
combo boxes behave more like the encoding menus.
2014-04-15 15:51:49 +02:00
Colomban Wendling
3ec0369f47 Merge branch 'wip/configurable-mime-type--gicon' into wip/configurable-mime-type-gicon 2014-04-14 20:27:20 +02:00
Colomban Wendling
bd6db90e29 Windows: add default extension to native save dialogs
Fixes bug #1021.

Based on an initial work by Steven Valsesia, thanks!
2014-03-11 15:50:39 +01:00
Colomban Wendling
7473e4b1d9 Add defensive checks for function receiving a GeanyDocument argument
Always check the passed-in GeanyDocument argument is a valid one, not
to possibly work on an invalid document.
2014-01-22 17:38:29 +01:00
Colomban Wendling
7c6f48e4f5 Workaround a slowness in multi-column combo boxes under GTK3
Always set the combo boxes' wrap-width after their models are fully
filled to work around dramatic slowness described in GTK bug
https://bugzilla.gnome.org/show_bug.cgi?id=722388
2014-01-18 03:13:05 +01:00
Colomban Wendling
1f2279aefe Always use proper functions argument lists 2013-11-10 01:43:10 +01:00
Colomban Wendling
01e7fe4b79 Use GIcon for the filetype icon rather than rendered pixbuf
This allows to re-use the icon more easily since it's not rendered at
a particular size but simply an icon description.  It also allows for
implicit icon updating when the theme changes if the display code
implements it (and GTK widgets does).
2013-10-15 15:56:44 +02:00
Nick Treleaven
0998f1c19c Make code more readable by renaming poorly named macros NZV and NVL
Closes #159
2013-08-14 21:54:20 -07:00
Nick Treleaven
c4f98d85cb Use proper string comparison for portability 2013-08-11 10:57:53 +01:00
Colomban Wendling
72c809f633 Use Glade to create the File Properties dialog 2013-05-20 04:12:44 +02:00
Colomban Wendling
2e9a1753d7 Fix internationalization of the File Properties dialog title 2013-05-20 01:50:02 +02:00
Colomban Wendling
e250ee8ec3 Fix version check for GtkFontChooserDialog (oops) 2013-01-29 15:49:39 +01:00
Colomban Wendling
8ece89096d Merge branch 'master' into gtk3-support 2013-01-29 15:29:10 +01:00
Colomban Wendling
bd02c009a1 Use the Geany icon from the theme everywhere 2013-01-01 19:10:04 +01:00
Nick Treleaven
c0a8a2b806 Disable 'Save As' dialog Rename button unless document exists on disk 2012-11-23 15:37:02 +00:00
Nick Treleaven
3949cf7304 Remove 'Open file in a new tab' save as option 2012-11-23 15:36:58 +00:00
Colomban Wendling
7d0adef31b Use GtkFontChooserDialog on GTK >= 3.2 for consistency
GtkFontButton uses GtkFontChooserDialog on GTK 3.2 so the UI is more
consistent if we use it explicitly too, and GtkFontSelectionDialog
is somewhat broken on 3.4.
2012-10-09 13:25:12 +02:00
Colomban Wendling
6409840d4a Get rid of GtkComboBoxEntry API and use GtkComboBoxText API
Use the GtkComboBoxText API and the GtkComboBoxEntry replacement API
and map those to the old equivalents if not available.

This changes the type exposed by ui_combo_box_add_to_history() from
GtkComboBoxEntry to either GtkComboBox (under GTK2) or GtkComboBoxText
(under GTK3).  This should not be too much of an issue since
GtkComboBoxEntry and GtkComboBoxtext are subclasses of GtkComboBox,
but this will still emit warnings when when the calling code passes
a GtkComboBoxEntry pointer to ui_combo_box_add_to_history().

However, this requires the calling code to use the same mapping as we
do (GtkComboBoxText = GtkComboBox on GTK2, even on 2.24), or things
will blow and it'll be hard to understand why.  This wouldn't be an
issue if the calling code includes our gtkcompat.h header everywhere
it deals with combo boxes, which will be the case if it includes the
Geany headers everywhere but probably won't otherwise.  Oh dear.

A possible kind of workaround may be for ui_combo_box_add_to_history()
to do type-checking on its argument and use the actually correct API
for that type.
2012-10-08 20:08:06 +02:00
Colomban Wendling
c1a7b1b475 Fix various packing issue affecting GTK3 but compatible with GTK2 2012-09-28 18:06:58 +02:00
Colomban Wendling
96afed1e9c Don't access GtkFontSelectionDialog fields directly
Also don't hack around and handle clicks on the dialog's buttons but
rather simply handler the dialog's response.
2012-09-13 16:34:18 +02:00
Colomban Wendling
d80bc7ce56 Update FSF address
Closes #3557875.
2012-08-24 19:25:57 +02:00
Colomban Wendling
1c2c455b1d Update copyright information 2012-06-18 01:15:04 +02:00
Matthew Brush
4e5a7231bf Always select current editor font when showing the font dialog
Previously, choosing another font and then pressing cancel would keep
the font selected rather than resetting it to the current editor font
because the dialog is not destroyed between showings.
2012-06-04 14:29:23 -07:00
Nick Treleaven
b287553e4a Use 'SETPTR' instead of 'setptr'
This makes it clearer we're using a macro.
2012-01-25 16:26:16 +00:00
Colomban Wendling
0aea05d10d Fix various integer signedness and minor styling issues
Most noteworthy change is that all build commands IDs and groups are
now unsigned everywhere negative values aren't explicitly handled with
a special meaning.  This should not change anything in behavior, only
makes clear the index won't underflow.
2011-12-18 00:32:22 +01:00
Matthew Brush
6cee28d677 Get rid of warning in on_file_notify()
Works around the issue discussed in commit 1e54fb6 by using the file
chooser's property accessor function.
Rename on_file_notify() to better explain its purpose.
2011-11-13 07:45:23 -08:00
Lex Trotman
1e54fb6a01 Alter warning fix
Uninitialised GValue does not always work, but is an opaque type so
structure of initialiser isn't known.  Glib 2.30 on has G_VALUE_INIT
to use as initial value.  Fix so if not defined give it the previous literal
value { 0 }, although this leaves the warning, so it is not initialising
the GValue correctly but enough to work.
2011-11-06 20:58:32 +11:00
Lex Trotman
4d92e0530b Fix warnings
Fix warnings that appeared with GCC 4.6
js.c:1067:10: warning: variable ‘is_prototype’ set but not used
dialogs.c:173:2: warning: missing initializer
dialogs.c:173:2: warning: (near initialization for ‘value.data’)
sidebar.c:534:17: warning: unused variable ‘doc’
2011-11-06 18:10:56 +11:00
Nick Treleaven
de559ef5d4 Make document_save_file() show the Save As dialog when necessary
Previously an error message was shown if doc->file_name is NULL.

The Save As dialog is now shown if the document does not have an
absolute path. This is because the user should confirm where to save
the document in this case.

Although this changes plugin API behaviour, it seems the best way to
ensure the Save As dialog is always shown when needed so the user
knows where the document has been saved.
2011-11-02 15:17:17 +00:00
Matthew Brush
a23e999b7b Bump GTK+ version to 2.16 2011-10-28 10:25:58 -07:00
Matthew Brush
bd5fba7eb5 Remove extra whitespace at end of lines in all source files.
* Processed with rstrip-whitespace.py script added to scripts/ directory.
* Script run on all .c and .h files in src/ and plugins/ directories.
* Also remove more than one newline at the end of files.
2011-10-11 21:52:58 -07:00
Matthew Brush
182bdc3b17 Replace GTK_BIN(...)->child with gtk_bin_get_child(...) 2011-10-11 21:30:28 -07:00
Colomban Wendling
010be558cd Plug a few memory leaks 2011-10-11 20:20:51 +02:00
Nick Treleaven
055779fb9f Cleanup dialogs_show_unsaved_file(). 2011-10-11 16:19:24 +01:00
Colomban Wendling
d06e9f4575 Remove $Id$ and $Date$ SVN keywords 2011-10-09 22:57:35 +02:00
Nick Treleaven
534f10454d Remove unnecessary document_show_tab() call (oops).
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@6018 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-10-07 16:50:15 +00:00
Nick Treleaven
1563c625f7 Add document_show_tab().
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@6017 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-10-07 16:47:31 +00:00
Nick Treleaven
5b220d70a2 * Merge branches/unstable:
- tagmanager/php.c:
   Fix parsing keyword-qualified functions strictly, e.g. don't 
   parse 'staticfunction' or 'fatfunction'.
 - src/utils.c, src/utils.h, src/editor.c:
   Use GRegex for snippet indentation replacement - fixes wrong 
   behaviour with Mac line endings.
 - tagmanager/lregex.c, TODO:
   Use GRegex for CTags instead of POSIX regex - GRegex is more 
   powerful. This also fixes a (HTML) performance issue on Windows. 
   Geany will now print a debug warning when using the "b" CTags 
   regex flag option for non-extended syntax. This is not currently 
   used by Geany's parsers.
   Note: GNU regex can't be removed yet as it's still used elsewhere 
   by Geany.
 - src/build.c, doc/pluginsignals.c:
   When saving on build, prompt for a filename if necessary.
   Emit the "build-start" signal only if saving succeeds.
 - src/build.c:
   Use #ifdef SYNC_SPAWN instead of G_OS_WIN32 for easier testing with 
   glib's asynchronous spawning (which doesn't work on Windows).
 - src/win32.c, src/win32.h, src/dialogs.c:
   Use GTK unsaved file dialog on Windows too because the button names 
   should be specific.



git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5987 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-10-03 14:35:11 +00:00
Nick Treleaven
6fb7d6c181 Fix string literal comparison warning.
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5945 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-09-22 12:05:05 +00:00
Nick Treleaven
a80bab9e3c Use GTK unsaved file dialog on Windows too because the button names
should be specific.



git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/branches/unstable@5941 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-09-21 15:35:38 +00:00
Colomban Wendling
ddb4ad5fa5 Fix some whitespace style errors
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5886 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-08-06 18:34:14 +00:00
Colomban Wendling
3bd6a01525 Fix a few signed vs. unsigned and differently-sized integer problems
Most notably, utils_get_line_endings() and document_open_file_list()
don't support -1 as the size anymore.  If the size should be computed
from null-terminated data, the caller code must take care of doing so.

git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5855 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-06-17 22:52:17 +00:00
Colomban Wendling
5d606ce351 Deprecate ui_widget_set_tooltip_text() in favor of gtk_widget_set_tooltip_text()
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5840 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-06-13 18:41:50 +00:00
Colomban Wendling
35ddfa4c70 Properly save and restore the encoding state in Open File dialog (oops)
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5838 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-06-10 23:13:08 +00:00
Colomban Wendling
f856ac782d Always destroy open and save dialog after use
Create and destroy the file open/save dialogs on each call rather than
keeping the same dialog around.  This avoids letting GTK monitor the
displayed directory for changes, thus probably reducing overhead and
works around GTK monitoring bugs.

This refactors the code a bit now it works a little differently.

Also fixes a bug that made dialogs_show_save_as() wrongly return the
first user response rather than the one that is actually used to make
the decision.  It happened for example when the user first selected an
non-writable location, or was asked whether to override a file and
answered "no".

Closes/references:
https://sourceforge.net/tracker/?func=detail&aid=3311687&group_id=153444&atid=787793
https://sourceforge.net/tracker/?func=detail&aid=3311258&group_id=153444&atid=787791
https://sourceforge.net/tracker/?func=detail&aid=3304273&group_id=153444&atid=787791
https://sourceforge.net/tracker/?func=detail&aid=3201050&group_id=153444&atid=787791
https://sourceforge.net/tracker/?func=detail&aid=3163742&group_id=153444&atid=787791
https://sourceforge.net/tracker/?func=detail&aid=3153120&group_id=153444&atid=787791
https://sourceforge.net/tracker/?func=detail&aid=2985896&group_id=153444&atid=787791
https://bugs.launchpad.net/ubuntu/+source/geany/+bug/754577

Dialog state restoration based on a patch by Matthew Brush, thanks.

git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5837 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-06-10 22:13:29 +00:00
Nick Treleaven
c3e5bd956c Use mimetype icon in File Properties dialog.
git-svn-id: https://geany.svn.sourceforge.net/svnroot/geany/trunk@5669 ea778897-0a13-0410-b9d1-a72fbfd435f5
2011-04-01 11:56:09 +00:00