4716 Commits

Author SHA1 Message Date
Matthew Brush
986c59aecb Use GeanyFiletypeGroupID enum in a few places
Also move the `group_menus` global variable to the top of the file
with the other globals.
2014-01-28 17:16:50 -08:00
Colomban Wendling
6a85a50d21 Replace bare CTags parser ID numbers with an enumeration
Avoid using magic numbers in the source for better readability and
easier maintenance.
2014-01-29 01:34:26 +01:00
Matthew Brush
576be4ca3b Reformat builtin filetype initialization code into tabular format
* Add an initialization function ft_init()
* Add a function-like macro to call ft_init() with shorter arguments
* Search and replace old code with FT_INIT() usage
* Layout into columns and add documentation above
2014-01-28 15:32:08 -08:00
Matthew Brush
c674f0660a Cleanup filetype_make_title() a bit and use it more
* Adds TITLE_NONE, TITLE_SCRIPT and TITLE_DOCUMENT.
* Only a few filetype titles were tweaked but we should review the
  rest as we could use TITLE_SCRIPT and TITLE_DOCUMENT a lot more
  probably.
* Make filetype_make_title() not care about GeanyFiletype type and
  return result instead of internally setting ft state.
2014-01-28 15:20:03 -08:00
Colomban Wendling
c2dcec7107 Don't use G_LIKELY() in macros commonly used in g_return_if_fail()
g_return_if_fail() puts itself its condition in a G_LIKELY() clause,
and nested G_LIKELY() lead to warnings about shadowed variables, as
well as not being of any use.

Also, hiding G_LIKELY() in a macro may lead to unexpected use of it
which may hint the compiler incorrectly.
2014-01-22 17:38:29 +01:00
Colomban Wendling
7473e4b1d9 Add defensive checks for function receiving a GeanyDocument argument
Always check the passed-in GeanyDocument argument is a valid one, not
to possibly work on an invalid document.
2014-01-22 17:38:29 +01:00
elextr
5d62030667 Fix "leaks" of geany_run_script (bug 975)
In build_run_cmd() the script was not deleted when any one of
several errors occurred.  The errors are not related to script
contents so it makes no sense to leave the script.

Also fixes failure to delete script if a working dir was set.
2014-01-22 09:15:25 +11:00
Colomban Wendling
7c6f48e4f5 Workaround a slowness in multi-column combo boxes under GTK3
Always set the combo boxes' wrap-width after their models are fully
filled to work around dramatic slowness described in GTK bug
https://bugzilla.gnome.org/show_bug.cgi?id=722388
2014-01-18 03:13:05 +01:00
SiegeLord
828df0ab5f Add shebang filetype detection for Rust 2014-01-14 12:50:38 -05:00
SiegeLord
3d7ade4e02 Integrate the Rust lexer with the rest of Geany's functionality 2014-01-14 12:50:38 -05:00
SiegeLord
a085573212 Use :: as the context separator for Rust 2014-01-14 12:50:37 -05:00
dobkeratops
b17b4be126 Added the Rust filetype 2014-01-14 12:50:37 -05:00
Colomban Wendling
1a5554c41c Add our stock icons manually
Although GtkIconFactory implements GtkBuildable properly and works just
fine, Glade can't handle it and keeps removing it upon save.  So, drop
the automatic setup to a manual one so the UI description is editable
with Glade again, and which also has the small advantage of not
repeating the stock ID strings.
2014-01-10 18:33:04 +01:00
Colomban Wendling
17a7469b68 Avoid a few unnecessary widget lookups 2014-01-09 17:50:30 +01:00
Colomban Wendling
680a556fff Find when activating the find entry in the replace dialog 2014-01-09 17:34:50 +01:00
Dimitar Zhekov
625c7b829d fix unexisting keys assigned to "Send selection to -> ..." 2014-01-09 15:27:51 +01:00
Colomban Wendling
4c8d2fb928 Fix handling of --list-documents when no other instance are running
Properly exit when passed --list-documents, even if no other instance
were already running.  This makes this option behave the same in any
case, making it easier to use in e.g. scripts.
2013-12-19 20:45:25 +01:00
Colomban Wendling
0eec7764af Fix truncation of the data retrieved with --list-documents
Do not truncate the document list to the size of the buffer used for
communication.

Since we now read multiple times, we need to make sure to always send
ETX so a reader don't hang reading the next chunk if the data sent had
exactly the size of the buffer.
2013-12-17 16:17:21 +01:00
Colomban Wendling
98b82550a8 Plug a few possible small memory leaks 2013-12-05 21:39:59 +01:00
Colomban Wendling
ddf67a8586 VTE: properly use the default value for invalid configured colors 2013-12-05 20:18:27 +01:00
Colomban Wendling
4aff511b01 Remove unnecessary allocation for VTE color settings 2013-12-05 20:16:54 +01:00
Colomban Wendling
69f1cc7136 Remove useless rotate_rgb() 2013-12-04 15:49:47 +01:00
Colomban Wendling
4ce6409e89 Remove useless utils_invert_color() 2013-12-04 15:46:05 +01:00
Colomban Wendling
8980970630 Unify color parsing
Change utils_parse_color() to use gdk_color_parse() and follow its
syntax, additionally supporting our "0x" prefix as a synonym for the
"#" prefix;  and use this everywhere.

Also add utils_color_to_bgr() and utils_parse_color_to_bgr() to provide
conversion to the 24 bits BGR format used by Scintilla.
2013-12-04 15:31:17 +01:00
Colomban Wendling
1590007862 Remove an unnecessary allocation 2013-12-04 14:59:05 +01:00
Colomban Wendling
3522e81d73 Merge branch 'wip/color-parsing-improvements' 2013-12-03 03:09:41 +01:00
Colomban Wendling
f07b5457d6 Simplify fold toggling code using higher-level Scintilla API 2013-12-02 23:19:44 +01:00
Colomban Wendling
3759562d7c Simplify reading highlighting colors with new utils_parse_color()
Drop redundant code converting # and short formats to hex colors now
utils_parse_color() can parse them.
2013-12-02 22:58:54 +01:00
Colomban Wendling
ebde42617a Accept colors with only 1 digit per channel in utils_parse_color()
AKA short HTML color notation.
2013-12-02 22:53:35 +01:00
Colomban Wendling
11a2f0ee91 Properly validate input in utils_parse_color() 2013-12-02 22:44:40 +01:00
Colomban Wendling
507005ca54 Rename utils_strtod() to utils_parse_color()
Rename the function to a more sensible name, and remove unnecessary
arguments.  Now, format (# or 0x) is auto-detected.
2013-12-02 22:38:11 +01:00
Colomban Wendling
f99e627bb0 Fix folding of the very last line in a level when unfolding children
Fix an off-by-one mistake resulting on the very last line of a nested
folded level not to be unfolded when recursively unfolding it's parent.

This was only visible when the last fold point was only one line long,
otherwise unfolding the (N-1)th line was enough.

Closes #1007.
2013-11-23 00:45:39 +01:00
Colomban Wendling
cff36e7497 R: properly display sources and libraries in the symbol list 2013-11-20 18:41:11 +01:00
Colomban Wendling
1dfc1077c7 Fix crash in fallback mime icon loading code under GTK3 2013-11-18 22:22:57 +01:00
Roland Pallai
b63eb87599 "Enter in replace entry does Replace & Find instead of Replace" setting
in General/Misc/Search.
2013-11-14 00:53:40 +01:00
Arthur Rosenstein
660c441b4a Don't prompt for reload confirmation if keeping edit history
No work is lost in that case (except for the redo stack, which is
normal), so the extra confirmation step seems bothersome.
2013-11-10 11:11:37 +02:00
Arthur Rosenstein
322fa65ff5 Maintain undo stack when reloading a document 2013-11-10 11:11:37 +02:00
Arthur Rosenstein
1b338d9d7d Add UNDO_RELOAD action 2013-11-10 11:11:36 +02:00
Arthur Rosenstein
9a03d32449 Add keep_edit_history_on_reload option
When this option is set, the undo stack is maintained when reloading a
document.
2013-11-10 11:11:35 +02:00
Arthur Rosenstein
1b1a1da4ed Clear redo stack when adding undo action
This fixes a bug in Geany where modifying the document does not clear the
redo actions stack.
2013-11-10 11:08:52 +02:00
Colomban Wendling
1f2279aefe Always use proper functions argument lists 2013-11-10 01:43:10 +01:00
Arthur Rosenstein
0a5378134a Add document_undo_clear_stack()
This function clears a single undo/redo stack.
2013-11-09 15:13:34 +02:00
Colomban Wendling
39fa004619 Fasten utils_tidy_path() a little and fix possible leaks in it
Fix possible leaks with bad paths, and also speed up some part of the
function by avoiding unnecessary allocations and string length
computations.
2013-11-07 23:11:15 +01:00
Colomban Wendling
c074817b8b Fix 2 unlikely memory leaks 2013-11-07 22:57:40 +01:00
Colomban Wendling
1d8dd84a47 Fix some small type issues in printf formats 2013-11-07 21:28:23 +01:00
Colomban Wendling
5c22c9d73e R has braces 2013-11-04 17:42:05 +01:00
Colomban Wendling
7b2f39a852 Remove an unused variable and plug a theoretical memory leak 2013-11-04 16:05:25 +01:00
Colomban Wendling
b2f4717ad3 Plug a memory leak on Windows 2013-11-03 23:35:55 +01:00
Colomban Wendling
5918532ab2 Explicit a valid cast 2013-11-03 22:31:00 +01:00
Colomban Wendling
cb588a1b82 Plug a possible memory leak 2013-11-03 22:30:55 +01:00