HybridDog/geany
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

plugins: enforce geany_plugin_register_proxy() can be called once

Browse Source 
In the future we might want to enable calling it again to set new supported
plugin types/extensions. This is not implemented yet, but in order to
allow this in the future we have to prevent it now, otherwise we'd
need to break the API.
This commit is contained in:
Thomas Martitz 2015-10-04 00:04:57 +02:00 committed by Colomban Wendling
parent 6dfe5ce942
commit 6cb443e863
1 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins.c
View File

@ -1985,6 +1985,8 @@ gboolean geany_plugin_register_proxy(GeanyPlugin *plugin, const gchar **extensio
{ {
Plugin *p; Plugin *p;
const gchar **ext; const gchar **ext;
PluginProxy *proxy;
GList *node;
g_return_val_if_fail(plugin != NULL, FALSE); g_return_val_if_fail(plugin != NULL, FALSE);
g_return_val_if_fail(extensions != NULL, FALSE); g_return_val_if_fail(extensions != NULL, FALSE);
@ -1993,10 +1995,17 @@ gboolean geany_plugin_register_proxy(GeanyPlugin *plugin, const gchar **extensio
g_return_val_if_fail(plugin->proxy_funcs->unload != NULL, FALSE); g_return_val_if_fail(plugin->proxy_funcs->unload != NULL, FALSE);
p = plugin->priv; p = plugin->priv;
/* Check if this was called aready. We want to reserve for the use case of calling
* this again to set new supported extensions (for example, based on proxy configuration). */
foreach_list(node, active_proxies.head)
{
proxy = node->data;
g_return_if_fail(p != proxy->plugin);
}
foreach_strv(ext, extensions) foreach_strv(ext, extensions)
{ {
PluginProxy *proxy = g_new(PluginProxy, 1); proxy = g_new(PluginProxy, 1);
g_strlcpy(proxy->extension, *ext, sizeof(proxy->extension)); g_strlcpy(proxy->extension, *ext, sizeof(proxy->extension));
proxy->plugin = p; proxy->plugin = p;
/* prepend, so that plugins automatically override core providers for a given extension */ /* prepend, so that plugins automatically override core providers for a given extension */