HybridDog/geany
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

TravisCI: Remove requirement to fail build on aggregate return (#1740)

Browse Source 
Returning large aggregates as values is a potential performance problem, but preventing all aggregate returns is inappropriate because:

1. returning small aggregates that are mostly handled as complete objects as return values often makes code clearer.

2. Modern (well not so modern actually) ABIs allow for small aggregates to be returned in registers, so forcing all returns to memory is actually likely to be slower.

3. if code review does not notice a large aggregate return and nobody notices a performance issue then it doesn't matter
This commit is contained in:
elextr 2018-01-13 15:03:22 +10:00 committed by Matthew Brush
parent cc035ab99d
commit 65097208df
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.travis.yml
View File

@ -21,7 +21,7 @@ install:
- sudo apt-get install -y --no-install-recommends doxygen - sudo apt-get install -y --no-install-recommends doxygen
- sudo apt-get install -y python-lxml - sudo apt-get install -y python-lxml
before_script: before_script:
- export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=aggregate-return -Werror=implicit-function-declaration" - export CFLAGS="-g -O2 -Werror=pointer-arith -Werror=implicit-function-declaration"
script: script:
- NOCONFIGURE=1 ./autogen.sh - NOCONFIGURE=1 ./autogen.sh
- > - >