HybridDog/geany
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix known memory leak in win32_show_folder_dialog()

Browse Source
This commit is contained in:
Matthew Brush 2015-12-13 15:30:34 -08:00
parent 402e669be1
commit 45f531cd4b
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/win32.c
View File

@ -284,7 +284,7 @@ INT CALLBACK BrowseCallbackProc(HWND hwnd, UINT uMsg, LPARAM lp, LPARAM pData)
gchar *win32_show_folder_dialog(GtkWidget *parent, const gchar *title, const gchar *initial_dir)
{
BROWSEINFOW bi;
LPCITEMIDLIST pidl;
LPITEMIDLIST pidl;
gchar *result = NULL;
wchar_t fname[MAX_PATH];
wchar_t w_title[512];
@ -305,14 +305,14 @@ gchar *win32_show_folder_dialog(GtkWidget *parent, const gchar *title, const gch
pidl = SHBrowseForFolderW(&bi);
/* convert the strange Windows folder list item something into an usual path string ;-) */
if (pidl != 0)
if (pidl != NULL)
{
if (SHGetPathFromIDListW(pidl, fname))
{
result = g_malloc0(MAX_PATH * 2);
WideCharToMultiByte(CP_UTF8, 0, fname, -1, result, MAX_PATH * 2, NULL, NULL);
}
/* SHBrowseForFolder() probably leaks memory here, but how to free the allocated memory? */
CoTaskMemFree(pidl);
}
return result;
}