[js] Don't improve TypeSets containing the magic-args type.
parent
63f4b4c30e
commit
dec19661db
|
@ -3823,7 +3823,7 @@ IonBuilder::improveTypesAtTypeOfCompare(MCompare* ins, bool trueBranch, MTest* t
|
||||||
tmp.addType(TypeSet::PrimitiveType(ValueTypeFromMIRType(subject->type())), alloc_->lifoAlloc());
|
tmp.addType(TypeSet::PrimitiveType(ValueTypeFromMIRType(subject->type())), alloc_->lifoAlloc());
|
||||||
}
|
}
|
||||||
|
|
||||||
if (inputTypes->unknown())
|
if (inputTypes->unknown() || inputTypes->hasType(TypeSet::MagicArgType()))
|
||||||
return true;
|
return true;
|
||||||
|
|
||||||
// Note: we cannot remove the AnyObject type in the false branch,
|
// Note: we cannot remove the AnyObject type in the false branch,
|
||||||
|
@ -3905,7 +3905,7 @@ IonBuilder::improveTypesAtNullOrUndefinedCompare(MCompare* ins, bool trueBranch,
|
||||||
tmp.addType(TypeSet::PrimitiveType(ValueTypeFromMIRType(subject->type())), alloc_->lifoAlloc());
|
tmp.addType(TypeSet::PrimitiveType(ValueTypeFromMIRType(subject->type())), alloc_->lifoAlloc());
|
||||||
}
|
}
|
||||||
|
|
||||||
if (inputTypes->unknown())
|
if (inputTypes->unknown() || inputTypes->hasType(TypeSet::MagicArgType()))
|
||||||
return true;
|
return true;
|
||||||
|
|
||||||
TemporaryTypeSet* type;
|
TemporaryTypeSet* type;
|
||||||
|
@ -3969,7 +3969,7 @@ IonBuilder::improveTypesAtTest(MDefinition* ins, bool trueBranch, MTest* test)
|
||||||
tmp.addType(TypeSet::PrimitiveType(ValueTypeFromMIRType(subject->type())), alloc_->lifoAlloc());
|
tmp.addType(TypeSet::PrimitiveType(ValueTypeFromMIRType(subject->type())), alloc_->lifoAlloc());
|
||||||
}
|
}
|
||||||
|
|
||||||
if (oldType->unknown())
|
if (oldType->unknown() || oldType->hasType(TypeSet::MagicArgType()))
|
||||||
return true;
|
return true;
|
||||||
|
|
||||||
TemporaryTypeSet* type = nullptr;
|
TemporaryTypeSet* type = nullptr;
|
||||||
|
@ -4049,7 +4049,7 @@ IonBuilder::improveTypesAtTest(MDefinition* ins, bool trueBranch, MTest* test)
|
||||||
}
|
}
|
||||||
|
|
||||||
// If ins does not have a typeset we return as we cannot optimize.
|
// If ins does not have a typeset we return as we cannot optimize.
|
||||||
if (oldType->unknown())
|
if (oldType->unknown() || oldType->hasType(TypeSet::MagicArgType()))
|
||||||
return true;
|
return true;
|
||||||
|
|
||||||
// Decide either to set or remove.
|
// Decide either to set or remove.
|
||||||
|
|
Loading…
Reference in New Issue