Feodor2
/
Mypal
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove harmless assertions by using IgnoredErrorResult

master
Fedor 2019-03-30 04:55:11 +03:00
parent 494cc091a1
commit 24e549b6f4
2 changed files with 7 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
dom/html/HTMLTableElement.cpp
View File

@ -421,11 +421,10 @@ HTMLTableElement::CreateTHead()
void void
HTMLTableElement::DeleteTHead() HTMLTableElement::DeleteTHead()
{ {
HTMLTableSectionElement* tHead = GetTHead(); RefPtr<HTMLTableSectionElement> tHead = GetTHead();
if (tHead) { if (tHead) {
mozilla::ErrorResult rv; mozilla::IgnoredErrorResult rv;
nsINode::RemoveChild(*tHead, rv); nsINode::RemoveChild(*tHead, rv);
MOZ_ASSERT(!rv.Failed());
} }
} }
@ -452,11 +451,10 @@ HTMLTableElement::CreateTFoot()
void void
HTMLTableElement::DeleteTFoot() HTMLTableElement::DeleteTFoot()
{ {
HTMLTableSectionElement* tFoot = GetTFoot(); RefPtr<HTMLTableSectionElement> tFoot = GetTFoot();
if (tFoot) { if (tFoot) {
mozilla::ErrorResult rv; mozilla::IgnoredErrorResult rv;
nsINode::RemoveChild(*tFoot, rv); nsINode::RemoveChild(*tFoot, rv);
MOZ_ASSERT(!rv.Failed());
} }
} }
@ -483,11 +481,10 @@ HTMLTableElement::CreateCaption()
void void
HTMLTableElement::DeleteCaption() HTMLTableElement::DeleteCaption()
{ {
HTMLTableCaptionElement* caption = GetCaption(); RefPtr<HTMLTableCaptionElement> caption = GetCaption();
if (caption) { if (caption) {
mozilla::ErrorResult rv; mozilla::IgnoredErrorResult rv;
nsINode::RemoveChild(*caption, rv); nsINode::RemoveChild(*caption, rv);
MOZ_ASSERT(!rv.Failed());
} }
} }

2
dom/html/HTMLTableSectionElement.cpp
View File

@ -122,7 +122,7 @@ HTMLTableSectionElement::DeleteRow(int32_t aValue, ErrorResult& aError)
refIndex = (uint32_t)aValue; refIndex = (uint32_t)aValue;
} }
nsINode* row = rows->Item(refIndex); nsCOMPtr<nsINode> row = rows->Item(refIndex);
if (!row) { if (!row) {
aError.Throw(NS_ERROR_DOM_INDEX_SIZE_ERR); aError.Throw(NS_ERROR_DOM_INDEX_SIZE_ERR);
return; return;