Emojigit/afch-zhwp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Include decline rationale in edit summary; misc decline copyedits

Browse Source
This commit is contained in:
theopolisme 2014-03-23 11:56:22 -05:00
parent 5284ad9097
commit bd932ce75b
2 changed files with 25 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
src/modules/submissions.js
View File

@ -1068,18 +1068,31 @@
// Also provide the values for each afch-input element
$( '.afch-input' ).each( function ( _, element ) {
var value;
var value, allTexts,
$element = $( element );
if ( element.type === 'checkbox' ) {
value = element.checked;
} else {
value = $( element ).val();
value = $element.val();
// For <select multiple> with nothing selected, jQuery returns null...
// convert that to an empty array so that $.each() won't explode later
if ( value === null ) {
value = [];
}
// Also provide the full text of the selected options in <select>.
// Primary use for this is the edit summary in handleDecline().
if ( element.nodeName.toLowerCase() === 'select' ) {
allTexts = [];
$element.find( 'option:selected' ).each( function () {
allTexts.push( $( this ).text() );
} );
data[element.id + 'Texts'] = allTexts;
}
}
data[element.id] = value;
@ -1696,7 +1709,9 @@
afchPage.edit( {
contents: text.get(),
summary: 'Declining submission'
// For the edit summary, we either grab the full summary text for the decline reason or,
// if it is a custom decline, just the full decline text instead.
summary: 'Declining submission: ' + ( declineReason !== 'reason' ? data.declineReasonTexts[0] : data.declineTextarea )
} );
if ( data.notifyUser ) {

14
src/templates/tpl-submissions.html
View File

@ -192,13 +192,13 @@
</optgroup>
<optgroup label="Notability">
<option value="neo">neo - Submission is about a neologisim that does not meet notability guidelines</option>
<option value="web">web - Submission is about web content does not meet notability guidelines</option>
<option value="prof">prof - Submission is about a professor does not meet notability guidelines</option>
<option value="athlete">athlete - Submission is about an athlete does not meet notability guidelines</option>
<option value="music">music - Submission is about a musician or musical work does not meet notability guidelines</option>
<option value="film">film - Submission is about a film does not meet notability guidelines</option>
<option value="corp">corp - Submission is about a company or organization does not meet notability guidelines</option>
<option value="bio">bio - Submission is about a person does not meet notability guidelines</option>
<option value="web">web - Submission is about web content that does not meet notability guidelines</option>
<option value="prof">prof - Submission is about a professor who does not meet notability guidelines</option>
<option value="athlete">athlete - Submission is about an athlete who does not meet notability guidelines</option>
<option value="music">music - Submission is about a musician or musical work that does not meet notability guidelines</option>
<option value="film">film - Submission is about a film that does not meet notability guidelines</option>
<option value="corp">corp - Submission is about a company or organization that does not meet notability guidelines</option>
<option value="bio">bio - Submission is about a person who does not meet notability guidelines</option>
<option value="nn">nn - Submission does not meet general notability guidelines (be more specific if possible)</option>
</optgroup>
<optgroup label="Invalid submissions">