Emojigit/afch-zhwp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Replace literal sigs with string concatenations

Browse Source 
i.e. no literal "~~~~", instead "~~"+"~~". Otherwise, there is the
potential for a bug if someone uploads the code by copying from the
source, and then their signature will get inserted
This commit is contained in:
Daniel Glus 2018-07-23 23:51:54 -04:00
parent 5ddb49f0d1
commit b9f3b76eee
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/modules/core.js
View File

@ -778,7 +778,7 @@
} ); } );
} }
appendText += ' ~~~~~\n'; appendText += ' ~~'+'~~'+'~\n';
logPage.edit( { logPage.edit( {
contents: appendText, contents: appendText,

10
src/modules/submissions.js
View File

@ -419,8 +419,8 @@
AFCH.Submission.prototype.addNewComment = function ( text ) { AFCH.Submission.prototype.addNewComment = function ( text ) {
var commentText = $.trim( text ); var commentText = $.trim( text );
if ( commentText.indexOf( '~~~~' ) === -1 ) { if ( commentText.indexOf( '~~' + '~~' ) === -1 ) {
commentText += ' ~~~~'; commentText += ' ~~' + '~~';
} }
this.comments.unshift( { this.comments.unshift( {
@ -1093,7 +1093,7 @@
// $1 = article name // $1 = article name
// $2 = article class or '' if not available // $2 = article class or '' if not available
'accepted-submission': '== Your submission at [[Wikipedia:Articles for creation|Articles for creation]]: ' + 'accepted-submission': '== Your submission at [[Wikipedia:Articles for creation|Articles for creation]]: ' +
'[[$1]] has been accepted ==\n{{subst:Afc talk|$1|class=$2|sig=~~~~}}', '[[$1]] has been accepted ==\n{{subst:Afc talk|$1|class=$2|sig=~~'+'~~}}',
// $1 = full submission title // $1 = full submission title
// $2 = short title // $2 = short title
@ -1110,9 +1110,9 @@
'comment-on-submission': '{{subst:AFC notification|comment|article=$1}}', 'comment-on-submission': '{{subst:AFC notification|comment|article=$1}}',
// $1 = article name // $1 = article name
'g13-submission': '{{subst:Db-afc-notice|$1}} ~~~~', 'g13-submission': '{{subst:Db-afc-notice|$1}} ~~'+'~~',
'teahouse-invite': '{{subst:Wikipedia:Teahouse/AFC invitation|sign=~~~~}}' 'teahouse-invite': '{{subst:Wikipedia:Teahouse/AFC invitation|sign=~~'+'~~}}'
} ); } );
} }