Merge branch 'bnoordhuis-fix879'

std/buf_map.zig

@@ -1,6 +1,8 @@
-const HashMap = @import("hash_map.zig").HashMap;
+const std = @import("index.zig");
-const mem = @import("mem.zig");
+const HashMap = std.HashMap;
+const mem = std.mem;
 const Allocator = mem.Allocator;
+const assert = std.debug.assert;
 
 /// BufMap copies keys and values before they go into the map, and
 /// frees them when they get removed.
@@ -28,18 +30,12 @@ pub const BufMap = struct {
     }
 
     pub fn set(self: &BufMap, key: []const u8, value: []const u8) !void {
-        if (self.hash_map.get(key)) |entry| {
+        self.delete(key);
-            const value_copy = try self.copy(value);
+        const key_copy = try self.copy(key);
-            errdefer self.free(value_copy);
+        errdefer self.free(key_copy);
-            _ = try self.hash_map.put(key, value_copy);
+        const value_copy = try self.copy(value);
-            self.free(entry.value);
+        errdefer self.free(value_copy);
-        } else {
+        _ = try self.hash_map.put(key_copy, value_copy);
-            const key_copy = try self.copy(key);
-            errdefer self.free(key_copy);
-            const value_copy = try self.copy(value);
-            errdefer self.free(value_copy);
-            _ = try self.hash_map.put(key_copy, value_copy);
-        }
     }
 
     pub fn get(self: &BufMap, key: []const u8) ?[]const u8 {
@@ -66,8 +62,29 @@ pub const BufMap = struct {
     }
 
     fn copy(self: &BufMap, value: []const u8) ![]const u8 {
-        const result = try self.hash_map.allocator.alloc(u8, value.len);
+        return mem.dupe(self.hash_map.allocator, u8, value);
-        mem.copy(u8, result, value);
-        return result;
     }
 };
+
+test "BufMap" {
+    var direct_allocator = std.heap.DirectAllocator.init();
+    defer direct_allocator.deinit();
+
+    var bufmap = BufMap.init(&direct_allocator.allocator);
+    defer bufmap.deinit();
+
+    try bufmap.set("x", "1");
+    assert(mem.eql(u8, ??bufmap.get("x"), "1"));
+    assert(1 == bufmap.count());
+
+    try bufmap.set("x", "2");
+    assert(mem.eql(u8, ??bufmap.get("x"), "2"));
+    assert(1 == bufmap.count());
+
+    try bufmap.set("x", "3");
+    assert(mem.eql(u8, ??bufmap.get("x"), "3"));
+    assert(1 == bufmap.count());
+
+    bufmap.delete("x");
+    assert(0 == bufmap.count());
+}

std/hash_map.zig

@@ -114,6 +114,7 @@ pub fn HashMap(comptime K: type, comptime V: type,
         }
 
         pub fn remove(hm: &Self, key: K) ?&Entry {
+            if (hm.entries.len == 0) return null;
             hm.incrementModificationCount();
             const start_index = hm.keyToIndex(key);
             {var roll_over: usize = 0; while (roll_over <= hm.max_distance_from_start_index) : (roll_over += 1) {
@@ -236,7 +237,10 @@ pub fn HashMap(comptime K: type, comptime V: type,
 }
 
 test "basic hash map usage" {
-    var map = HashMap(i32, i32, hash_i32, eql_i32).init(debug.global_allocator);
+    var direct_allocator = std.heap.DirectAllocator.init();
+    defer direct_allocator.deinit();
+
+    var map = HashMap(i32, i32, hash_i32, eql_i32).init(&direct_allocator.allocator);
     defer map.deinit();
 
     assert((map.put(1, 11) catch unreachable) == null);