Ekdohibs/zig
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add unused label error

Browse Source
This commit is contained in:
Andrew Kelley 2015-12-05 21:04:57 -07:00
parent f49e857b9b
commit daa3b6bfa3
4 changed files with 24 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
README.md
View File

@ -42,8 +42,6 @@ make
## Roadmap ## Roadmap
* parseh: unreachable <--> noreturn attribute
* unused label error
* loops * loops
* structs * structs
* tagged enums * tagged enums

18
src/analyze.cpp
View File

@ -471,6 +471,7 @@ static TypeTableEntry * analyze_expression(CodeGen *g, ImportTableEntry *import,
assert(!node->codegen_node); assert(!node->codegen_node);
node->codegen_node = allocate<CodeGenNode>(1); node->codegen_node = allocate<CodeGenNode>(1);
node->codegen_node->data.label_entry = table_entry->value; node->codegen_node->data.label_entry = table_entry->value;
table_entry->value->used = true;
} else { } else {
add_node_error(g, node, add_node_error(g, node,
buf_sprintf("use of undeclared label '%s'", buf_ptr(&node->data.go_to.name))); buf_sprintf("use of undeclared label '%s'", buf_ptr(&node->data.go_to.name)));
@ -758,6 +759,23 @@ static void analyze_top_level_declaration(CodeGen *g, ImportTableEntry *import,
node->codegen_node = allocate<CodeGenNode>(1); node->codegen_node = allocate<CodeGenNode>(1);
node->codegen_node->data.fn_def_node.implicit_return_type = block_return_type; node->codegen_node->data.fn_def_node.implicit_return_type = block_return_type;
node->codegen_node->data.fn_def_node.block_context = context; node->codegen_node->data.fn_def_node.block_context = context;
{
FnTableEntry *fn_table_entry = fn_proto_node->codegen_node->data.fn_proto_node.fn_table_entry;
auto it = fn_table_entry->label_table.entry_iterator();
for (;;) {
auto *entry = it.next();
if (!entry)
break;
LabelTableEntry *label_entry = entry->value;
if (!label_entry->used) {
add_node_error(g, label_entry->label_node,
buf_sprintf("label '%s' defined but not used",
buf_ptr(&label_entry->label_node->data.label.name)));
}
}
}
} }
break; break;

1
src/semantic_info.hpp
View File

@ -41,6 +41,7 @@ struct ImportTableEntry {
struct LabelTableEntry { struct LabelTableEntry {
AstNode *label_node; AstNode *label_node;
LLVMBasicBlockRef basic_block; LLVMBasicBlockRef basic_block;
bool used;
}; };
struct FnTableEntry { struct FnTableEntry {

5
test/run_tests.cpp
View File

@ -466,6 +466,11 @@ fn f(a : unreachable) {}
export fn f(a : void) {} export fn f(a : void) {}
)SOURCE", 1, ".tmp_source.zig:2:17: error: parameter of type 'void' not allowed on exported functions"); )SOURCE", 1, ".tmp_source.zig:2:17: error: parameter of type 'void' not allowed on exported functions");
add_compile_fail_case("unused label", R"SOURCE(
export fn f() {
a_label:
}
)SOURCE", 1, ".tmp_source.zig:3:1: error: label 'a_label' defined but not used");
} }
static void print_compiler_invocation(TestCase *test_case, Buf *zig_stderr) { static void print_compiler_invocation(TestCase *test_case, Buf *zig_stderr) {