Ekdohibs
/
zig
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix missing compile error on call assigned to const

master
Vexu 2020-05-04 14:28:58 +03:00
parent e72f45475d
commit adc444ceeb
No known key found for this signature in database
GPG Key ID: 59AEB8936E16A6AC
2 changed files with 33 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/ir.cpp
View File

@ -20000,6 +20000,11 @@ static IrInstGen *ir_analyze_fn_call(IrAnalyze *ira, IrInst* source_instr,
if (type_is_invalid(result_loc->value->type) || result_loc->value->type->id == ZigTypeIdUnreachable) { if (type_is_invalid(result_loc->value->type) || result_loc->value->type->id == ZigTypeIdUnreachable) {
return result_loc; return result_loc;
} }
if (result_loc->value->type->data.pointer.is_const) {
ir_add_error(ira, source_instr, buf_sprintf("cannot assign to constant"));
return ira->codegen->invalid_inst_gen;
}
IrInstGen *dummy_value = ir_const(ira, source_instr, impl_fn_type_id->return_type); IrInstGen *dummy_value = ir_const(ira, source_instr, impl_fn_type_id->return_type);
dummy_value->value->special = ConstValSpecialRuntime; dummy_value->value->special = ConstValSpecialRuntime;
IrInstGen *dummy_result = ir_implicit_cast2(ira, source_instr, IrInstGen *dummy_result = ir_implicit_cast2(ira, source_instr,
@ -20138,6 +20143,11 @@ static IrInstGen *ir_analyze_fn_call(IrAnalyze *ira, IrInst* source_instr,
if (type_is_invalid(result_loc->value->type) || result_loc->value->type->id == ZigTypeIdUnreachable) { if (type_is_invalid(result_loc->value->type) || result_loc->value->type->id == ZigTypeIdUnreachable) {
return result_loc; return result_loc;
} }
if (result_loc->value->type->data.pointer.is_const) {
ir_add_error(ira, source_instr, buf_sprintf("cannot assign to constant"));
return ira->codegen->invalid_inst_gen;
}
IrInstGen *dummy_value = ir_const(ira, source_instr, return_type); IrInstGen *dummy_value = ir_const(ira, source_instr, return_type);
dummy_value->value->special = ConstValSpecialRuntime; dummy_value->value->special = ConstValSpecialRuntime;
IrInstGen *dummy_result = ir_implicit_cast2(ira, source_instr, IrInstGen *dummy_result = ir_implicit_cast2(ira, source_instr,

23
test/compile_errors.zig
View File

@ -2,6 +2,29 @@ const tests = @import("tests.zig");
const std = @import("std"); const std = @import("std");
pub fn addCases(cases: *tests.CompileErrorContext) void { pub fn addCases(cases: *tests.CompileErrorContext) void {
cases.add("call assigned to constant",
\\const Foo = struct {
\\ x: i32,
\\};
\\fn foo() Foo {
\\ return .{ .x = 42 };
\\}
\\fn bar(val: var) Foo {
\\ return .{ .x = val };
\\}
\\export fn entry() void {
\\ const baz: Foo = undefined;
\\ baz = foo();
\\}
\\export fn entry1() void {
\\ const baz: Foo = undefined;
\\ baz = bar(42);
\\}
, &[_][]const u8{
"tmp.zig:12:14: error: cannot assign to constant",
"tmp.zig:16:14: error: cannot assign to constant",
});
cases.add("invalid pointer syntax", cases.add("invalid pointer syntax",
\\export fn foo() void { \\export fn foo() void {
\\ var guid: *:0 const u8 = undefined; \\ var guid: *:0 const u8 = undefined;