Ekdohibs
/
zig
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

child process: no need to remove O_CLOEXEC before execve

master
Andrew Kelley 2020-05-02 03:38:05 -04:00
parent 92f3e9c92a
commit 6546c74825
1 changed files with 0 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/std/child_process.zig
View File

@ -421,16 +421,6 @@ pub const ChildProcess = struct {
} }
if (self.cwd_dir) |cwd| { if (self.cwd_dir) |cwd| {
// Remove the O_CLOEXEC flag. This is the only safe time to do it, between fork() and execve().
var flags = os.fcntl(cwd.fd, os.F_GETFD, 0) catch |err| switch (err) {
error.Locked => unreachable,
else => |e| forkChildErrReport(err_pipe[1], e),
};
flags &= ~@as(u32, os.O_CLOEXEC);
_ = os.fcntl(cwd.fd, os.F_SETFD, flags) catch |err| switch (err) {
error.Locked => unreachable,
else => |e| forkChildErrReport(err_pipe[1], e),
};
os.fchdir(cwd.fd) catch |err| forkChildErrReport(err_pipe[1], err); os.fchdir(cwd.fd) catch |err| forkChildErrReport(err_pipe[1], err);
} else if (self.cwd) |cwd| { } else if (self.cwd) |cwd| {
os.chdir(cwd) catch |err| forkChildErrReport(err_pipe[1], err); os.chdir(cwd) catch |err| forkChildErrReport(err_pipe[1], err);