Ekdohibs
/
zig
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

more robust detection of types that failed to resolve

master
Andrew Kelley 2017-02-20 19:56:07 -05:00
parent c4ee37f506
commit 4709fe1176
3 changed files with 247 additions and 197 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/analyze.cpp
View File

@ -1120,6 +1120,8 @@ bool type_is_invalid(TypeTableEntry *type_entry) {
return type_entry->data.enumeration.is_invalid;
case TypeTableEntryIdUnion:
return type_entry->data.unionation.is_invalid;
case TypeTableEntryIdTypeDecl:
return type_is_invalid(type_entry->data.type_decl.canonical_type);
default:
return false;
}

396
src/ir.cpp
View File

File diff suppressed because it is too large Load Diff

46
test/run_tests.cpp
View File

@ -93,10 +93,9 @@ static TestCase *add_simple_case_libc(const char *case_name, const char *source,
return tc;
}
static TestCase *add_compile_fail_case(const char *case_name, const char *source, size_t count, ...) {
va_list ap;
va_start(ap, count);
static TestCase *add_compile_fail_case_extra(const char *case_name, const char *source, bool check_unused,
size_t count, va_list ap)
{
TestCase *test_case = allocate<TestCase>(1);
test_case->case_name = case_name;
test_case->source_files.resize(1);
@ -122,15 +121,32 @@ static TestCase *add_compile_fail_case(const char *case_name, const char *source
test_case->compiler_args.append("--release");
test_case->compiler_args.append("--strip");
test_case->compiler_args.append("--check-unused");
if (check_unused) {
test_case->compiler_args.append("--check-unused");
}
test_cases.append(test_case);
va_end(ap);
return test_case;
}
static TestCase *add_compile_fail_case_no_check_unused(const char *case_name, const char *source, size_t count, ...) {
va_list ap;
va_start(ap, count);
TestCase *result = add_compile_fail_case_extra(case_name, source, false, count, ap);
va_end(ap);
return result;
}
static TestCase *add_compile_fail_case(const char *case_name, const char *source, size_t count, ...) {
va_list ap;
va_start(ap, count);
TestCase *result = add_compile_fail_case_extra(case_name, source, true, count, ap);
va_end(ap);
return result;
}
static void add_debug_safety_case(const char *case_name, const char *source) {
{
TestCase *test_case = allocate<TestCase>(1);
@ -1646,6 +1662,22 @@ fn bar(x: &const u3) -> u3 {
}
)SOURCE", 1, ".tmp_source.zig:12:26: error: expected type '&const u3', found '&:3:6 const u3'");
add_compile_fail_case_no_check_unused("referring to a struct that is invalid without --check-unused", R"SOURCE(
const UsbDeviceRequest = struct {
Type: u8,
};
export fn foo() {
comptime assert(@sizeOf(UsbDeviceRequest) == 0x8);
}
fn assert(ok: bool) {
if (!ok) @unreachable();
}
)SOURCE", 2,
".tmp_source.zig:11:14: error: unable to evaluate constant expression",
".tmp_source.zig:7:20: note: called from here");
}
//////////////////////////////////////////////////////////////////////////////