Ekdohibs/zig
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix handling multiple extern vars with the same name

Browse Source
This commit is contained in:
Andrew Kelley 2018-08-25 03:55:32 -04:00
parent b95ff12f2f
commit 02f5a9fa62
1 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/codegen.cpp
View File

@ -5812,12 +5812,16 @@ static void do_code_gen(CodeGen *g) {
LLVMValueRef global_value; LLVMValueRef global_value;
if (var->linkage == VarLinkageExternal) { if (var->linkage == VarLinkageExternal) {
global_value = LLVMAddGlobal(g->module, var->value->type->type_ref, buf_ptr(&var->name)); LLVMValueRef existing_llvm_var = LLVMGetNamedGlobal(g->module, buf_ptr(&var->name));
if (existing_llvm_var) {
global_value = LLVMConstBitCast(existing_llvm_var, LLVMPointerType(var->value->type->type_ref, 0));
} else {
global_value = LLVMAddGlobal(g->module, var->value->type->type_ref, buf_ptr(&var->name));
// TODO debug info for the extern variable
// TODO debug info for the extern variable LLVMSetLinkage(global_value, LLVMExternalLinkage);
LLVMSetAlignment(global_value, var->align_bytes);
LLVMSetLinkage(global_value, LLVMExternalLinkage); }
LLVMSetAlignment(global_value, var->align_bytes);
} else { } else {
bool exported = (var->linkage == VarLinkageExport); bool exported = (var->linkage == VarLinkageExport);
const char *mangled_name = buf_ptr(get_mangled_name(g, &var->name, exported)); const char *mangled_name = buf_ptr(get_mangled_name(g, &var->name, exported));