apply shellcheck recommendations on player-mpris-tail

This commit is contained in:
x70b1 2018-04-19 07:02:22 +02:00
parent 1969d85160
commit 26ed37ea55

View File

@ -1,10 +1,8 @@
#!/usr/bin/env bash
function listPlayers {
echo "$(dbus-send --session --dest=org.freedesktop.DBus \
--type=method_call --print-reply /org/freedesktop/DBus \
org.freedesktop.DBus.ListNames | grep org.mpris.MediaPlayer2 |
awk -F\" '{print $2}' | cut -d '.' -f4- )"
dbus-send --session --dest=org.freedesktop.DBus --type=method_call --print-reply /org/freedesktop/DBus \
org.freedesktop.DBus.ListNames | grep org.mpris.MediaPlayer2 | awk -F\" '{print $2}' | cut -d '.' -f4-
}
function getPlayerStatus {
@ -12,16 +10,16 @@ function getPlayerStatus {
}
function getActivePlayer {
players=($(listPlayers))
for player in ${players[@]}; do
players=("$(listPlayers)")
for player in "${players[@]}"; do
if [ "$(getPlayerStatus "${player}")" == "Playing" ]; then
playing=$player
fi
fi
done
for player in ${players[@]}; do
for player in "${players[@]}"; do
if [ "$(getPlayerStatus "${player}")" == "Paused" ]; then
paused=$player
fi
fi
done
if [ -n "$playing" ]; then
echo "$playing"
@ -29,7 +27,7 @@ function getActivePlayer {
echo "$paused"
else
# Return last (newest?) player
echo ${players[@]: -1}
echo "${players[@]: -1}"
fi
}