Ekdohibs
/
ocaml
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

typemod: fix uncaught Nondep_cannot_erase exception

master
Thomas Refis 2018-10-29 15:14:58 +00:00
parent 09112aca7e
commit 4bc69008a9
2 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
testsuite/tests/typing-modules/nondep.ml
View File

@ -11,6 +11,11 @@ module F : functor (X : sig type t end) -> sig val f : X.t -> unit end
module M = F(struct type t = T end);;
[%%expect{|
Uncaught exception: Ctype.Nondep_cannot_erase(_)
Line 1, characters 11-35:
1 | module M = F(struct type t = T end);;
^^^^^^^^^^^^^^^^^^^^^^^^
Error: This functor has type
functor (X : sig type t end) -> sig val f : X.t -> unit end
The parameter cannot be eliminated in the result type.
Please bind the argument to a module identifier.
|}]

4
typing/typemod.ml
View File

@ -1621,7 +1621,7 @@ and type_module_aux ~alias sttn funct_body anchor env smod =
"the signature of this functor application" mty_res;
let nondep_mty =
try Mtype.nondep_supertype env [param] mty_res
with Not_found ->
with Ctype.Nondep_cannot_erase _ ->
raise(Error(smod.pmod_loc, env,
Cannot_eliminate_dependency mty_functor))
in
@ -2259,7 +2259,7 @@ let report_error ppf = function
| Cannot_eliminate_dependency mty ->
fprintf ppf
"@[This functor has type@ %a@ \
The parameter cannot be eliminated in the result type.@ \
The parameter cannot be eliminated in the result type.@ \
Please bind the argument to a module identifier.@]" modtype mty
| Signature_expected -> fprintf ppf "This module type is not a signature"
| Structure_expected mty ->