Fix some valgrind errors

by 0x5DE892: _c_ResourceManager__paths (ResourceManager.m:458)
by 0x4B45D2: _i_PlayerEntity_Scripting_removeAllCargo_ (PlayerEntityLegacyScriptEngine.m:1410)
by 0x64FF8D: _i_OOALBufferedSound__initWithDecoder_ (OOALBufferedSound.m:64)
by 0x45A69A: _i_PlayerEntity__setUpAndConfirmOK_saveGame_ (PlayerEntity.m:1803)
by 0x45AD59: _i_PlayerEntity__setUpAndConfirmOK_saveGame_ (PlayerEntity.m:1878)
by 0x64C5A2: _i_OOSoundSourcePool__initWithCount_minRepeatTime_ (OOSoundSourcePool.m:76)
by 0x6628FA: _i_HeadUpDisplay__initWithDictionary_inFile_ (HeadUpDisplay.m:296)
by 0x4C673C: _i_PlayerEntity_Sound_setUpSound (PlayerEntitySound.m:86)
by 0x4598FE: _i_PlayerEntity__setUpAndConfirmOK_saveGame_ (PlayerEntity.m:1683)
by 0x45999F: _i_PlayerEntity__setUpAndConfirmOK_saveGame_ (PlayerEntity.m:1688)
by 0x459FAD: _i_PlayerEntity__setUpAndConfirmOK_saveGame_ (PlayerEntity.m:1733)
by 0x4599F8: _i_PlayerEntity__setUpAndConfirmOK_saveGame_ (PlayerEntity.m:1690)
by 0x66218B: _i_HeadUpDisplay__initWithDictionary_inFile_ (HeadUpDisplay.m:230)
by 0x6001B0: InitOOJSManifest (OOJSManifest.m:203)

src/Core/Entities/PlayerEntity.m

@@ -1172,6 +1172,7 @@ static GLfloat		sBaseMass = 0.0;
 	[self initialiseMissionDestinations:newDestinations andLegacy:legacyDestinations];
 	
 	// shipyard
+	DESTROY(shipyard_record);
 	shipyard_record = [[dict oo_dictionaryForKey:@"shipyard_record"] mutableCopy];
 	if (shipyard_record == nil)  shipyard_record = [[NSMutableDictionary alloc] init];
 	
@@ -1539,6 +1540,7 @@ static GLfloat		sBaseMass = 0.0;
 	
 	target_memory_index = 0;
 	
+	DESTROY(dockingReport);
 	dockingReport = [[NSMutableString alloc] init];
 	[hud resetGuis:[NSDictionary dictionaryWithObjectsAndKeys:[NSDictionary dictionaryWithObjectsAndKeys:nil], @"message_gui",
 														[NSDictionary dictionaryWithObjectsAndKeys:nil], @"comm_log_gui", nil]];
@@ -1680,13 +1682,16 @@ static GLfloat		sBaseMass = 0.0;
 	[reputation oo_setInteger:0 forKey:PARCEL_BAD_KEY];
 	[reputation oo_setInteger:MAX_CONTRACT_REP forKey:PARCEL_UNKNOWN_KEY];
 	
+	DESTROY(roleWeights);
 	roleWeights = [[NSMutableArray alloc] initWithCapacity:8];
 	for (i = 0 ; i < 8 ; i++)
 	{
 		[roleWeights addObject:@"player-unknown"];
 	}
+	DESTROY(roleWeightFlags);
 	roleWeightFlags = [[NSMutableDictionary alloc] init];
 
+	DESTROY(roleSystemList);
 	roleSystemList = [[NSMutableArray alloc] initWithCapacity:32];
 
 	energy					= 256;
@@ -1793,6 +1798,7 @@ static GLfloat		sBaseMass = 0.0;
 	
 	max_cargo				= 20; // will be reset later
 	
+	DESTROY(shipCommodityData);
 	shipCommodityData = [[[ResourceManager dictionaryFromFilesNamed:@"commodities.plist" inFolder:@"Config" andMerge:YES] objectForKey:@"default"] retain];
 	
 	// set up missiles
@@ -2029,6 +2035,7 @@ static GLfloat		sBaseMass = 0.0;
 	DESTROY(_fastEquipmentA);
 	DESTROY(_fastEquipmentB);
 
+	DESTROY(eqScripts);
 	DESTROY(worldScripts);
 	DESTROY(worldScriptsRequiringTickle);
 	DESTROY(mission_variables);

src/Core/Entities/PlayerEntitySound.m

@@ -108,6 +108,7 @@ static const Vector	 kAfterburner2Position		= { 0.1f, 0.0f, -1.0f };
 	DESTROY(sWarningSoundPool);
 	DESTROY(sWeaponSoundPool);
 	DESTROY(sDamageSoundPool);
+	DESTROY(sMiscSoundPool);
 }
 
 

src/Core/HeadUpDisplay.m

@@ -307,11 +307,13 @@ OOINLINE void GLColorWithOverallAlpha(const GLfloat *color, GLfloat alpha)
 - (void) dealloc
 {
 	DESTROY(legendArray);
-	DESTROY(dialArray);
+	DESTROY(dialArray);	
+	DESTROY(mfdArray);
 	DESTROY(hudName);
 	DESTROY(deferredHudName);
 	DESTROY(propertiesReticleTargetSensitive);
 	DESTROY(_crosshairOverrides);
+	DESTROY(_crosshairColor);
 	DESTROY(crosshairDefinition);
 	DESTROY(_hiddenSelectors);
 

src/Core/OOALBufferedSound.m

@@ -35,6 +35,7 @@ SOFTWARE.
 {
 	free(_buffer);
 	_buffer = NULL;
+	DESTROY(_name);
 	
 	[super dealloc];
 }

src/Core/OOShipRegistry.m

@@ -134,6 +134,9 @@ static NSString * const	kVisualEffectDataCacheKey = @"visual effect data";
 {
 	if (sSingleton != nil)
 	{
+		/* CIM: 'release' doesn't work - the class definition
+		 * overrides it, so this leaks memory. Needs a proper reset
+		 * method for reloading the ship registry data instead */
 		[sSingleton release];
 		sSingleton = nil;
 		

src/Core/OOSoundSourcePool.m

@@ -92,7 +92,8 @@ typedef struct OOSoundSourcePoolElement
 	{
 		[_sources[i].source release];
 	}
-	
+	free(_sources);
+
 	[_lastKey release];
 	
 	[super dealloc];

src/Core/ResourceManager.m

@@ -259,6 +259,7 @@ static NSMutableDictionary *sStringCache;
 	}
 	
 	// validate default search paths
+	DESTROY(sSearchPaths);
 	sSearchPaths = [NSMutableArray new];
 	foreach(path, existingRootPaths)
 	{

src/Core/Scripting/OOJSManifest.m

@@ -200,6 +200,7 @@ void InitOOJSManifest(JSContext *context, JSObject *global)
 	}
 	
 	// EMMSTRAN: use NSMapTable. -- Ahruman 2011-02-10
+	DESTROY(sManifestNameMap);
 	sManifestNameMap = [[NSMutableDictionary alloc] initWithDictionary:manifestNameMap];
 }